Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Distr-PR-2 Truncate Decimal Functionality #2379

Merged
merged 18 commits into from
Sep 25, 2018
Merged

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Sep 22, 2018

For distribution PR (ref #2236)
Merge to develop (change base required) after Distr-PR-1 (ref #2369) merged

Closes #2378

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski added ready-for-review C:x/distribution distribution module related labels Sep 22, 2018
@rigelrozanski rigelrozanski changed the base branch from develop to rigel/stake-cons-addr September 22, 2018 18:03
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe add a changelog entry? Other than that seems good to merge

@rigelrozanski rigelrozanski changed the title R4R: Distr-PR-1 Truncate Decimal Functionality R4R: Distr-PR-2 Truncate Decimal Functionality Sep 22, 2018
@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

Merging #2379 into rigel/stake-cons-addr will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           rigel/stake-cons-addr    #2379   +/-   ##
======================================================
  Coverage                  63.54%   63.54%           
======================================================
  Files                        120      120           
  Lines                       7236     7236           
======================================================
  Hits                        4598     4598           
  Misses                      2326     2326           
  Partials                     312      312

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but left a remark on clarity.

types/decimal.go Show resolved Hide resolved
types/decimal.go Outdated Show resolved Hide resolved
@jaekwon jaekwon changed the base branch from rigel/stake-cons-addr to develop September 25, 2018 04:10
@jaekwon jaekwon merged commit de30281 into develop Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants