-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Distr-PR-2 Truncate Decimal Functionality #2379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Maybe add a changelog entry? Other than that seems good to merge
Codecov Report
@@ Coverage Diff @@
## rigel/stake-cons-addr #2379 +/- ##
======================================================
Coverage 63.54% 63.54%
======================================================
Files 120 120
Lines 7236 7236
======================================================
Hits 4598 4598
Misses 2326 2326
Partials 312 312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but left a remark on clarity.
For distribution PR (ref #2236)
Merge to
develop
(change base required) after Distr-PR-1 (ref #2369) mergedCloses #2378
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: