Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix dead link in UPGRADING.md #23059

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

BabyHalimao
Copy link
Contributor

@BabyHalimao BabyHalimao commented Dec 21, 2024

Description

simapp/CHANGELOG.md was removed in PR #23009 , but this file is required in UPGRADING.md.

In this section we describe the changes made in Cosmos SDK' SimApp.
These changes are directly applicable to your application wiring.
Please read this section first, but for an exhaustive list of changes, refer to the CHANGELOG.

Maybe this file was mis-deleted and should be recovered?

Summary by CodeRabbit

  • Documentation
    • Updated UPGRADING.md to reflect significant changes in the Cosmos SDK.
    • Removed the x/params module and added the x/protocolpool module.
    • Clarified migration processes and new features, including unordered transactions and expedited proposals.
    • Provided guidance on necessary code adjustments for developers.

Copy link
Contributor

coderabbitai bot commented Dec 21, 2024

📝 Walkthrough

Walkthrough

The pull request focuses on updating the UPGRADING.md document to reflect significant changes in the Cosmos SDK. The modifications cover multiple aspects of the SDK, including module removals and additions, method signature updates, and changes in application wiring. Key updates involve the deprecation of the x/params module, introduction of the x/protocolpool module, and substantial changes to method signatures across various components. The document provides comprehensive guidance for developers on migrating to the new SDK version, highlighting important structural and functional modifications.

Changes

File Change Summary
UPGRADING.md - Removed x/params module
- Added x/protocolpool module
- Updated method signatures for AppModule, SimApp
- Modified context handling in various methods
- Updated upgrade handling logic
- Introduced changes in application wiring

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant App as SimApp
    participant Module as Modules
    participant Context as Context Management

    Dev->>App: Initialize Application
    App->>Context: Transition to new Context handling
    App->>Module: Update Module Interfaces
    Module->>App: Implement New Method Signatures
    Dev->>App: Migrate Upgrade Handlers
    App->>Module: Apply Consensus Parameters
Loading

Possibly related PRs

Suggested labels

backport/v0.52.x, C:Simulations, C:core/testing

Suggested reviewers

  • julienrbrt
  • sontrinh16
  • facundomedica
  • akhilkumarpilli

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
simapp/CHANGELOG.md (4)

24-30: Consider clarifying the relationship with UPGRADING.md

While the introduction is clear, it would be helpful to explicitly state that this changelog complements the SimApp section in UPGRADING.md by providing detailed implementation changes.

 This changelog is aimed to help developers understand the wiring changes between SDK versions.
-It is an exhaustive list of changes that completes the SimApp section in the [UPGRADING.md](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#simapp)
+It provides an exhaustive list of implementation-specific changes that complements the high-level migration guide in [UPGRADING.md](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#simapp).

31-50: Restructure changes according to the guidelines

The changelog entries should be grouped by type (Features, Improvements, API Breaking, etc.) as specified in the guidelines.

Consider reorganizing the changes like this:

 ## v0.50 to v0.52

 Always refer to the [UPGRADING.md](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md) to understand the changes.

+### Features
+* Wire new SDK modules (`epochs`, `accounts`, `protocolpool`).
+* Add example of how to define a custom mint function in `simapp/mint_fn.go`.
+* Add address codec in client context and signing context.
+
+### Improvements
+* Update `export` function to make use of the new module collections API.
+* Update testnet command to match new module APIs.
+* [#20740] Update `genutilcli.Commands` to use the genutil modules from the module manager.
+* [#20490] Refactor simulations to make use of `testutil/sims` instead of `runsims`.
+
+### API Breaking
+* Update module path to new vanity url.
+* Remove the crisis module from simapp.
+* [#20485] The signature of `x/upgrade/types.UpgradeHandler` has changed...

51-51: Clarify or remove the TODO comment

The TODO comment "move changelog.md elements to here" lacks context and specificity about what needs to be moved.

Would you like me to help clarify this TODO or open an issue to track this task?


53-63: Consider adding version release dates

For better historical tracking, consider adding release dates to each version section, following the principle mentioned in the guidelines: "The release date of each version is displayed."

-## v0.47 to v0.50
+## v0.47 to v0.50 (Released 2023-XX-XX)
📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c12136b and 1615459.

📒 Files selected for processing (1)
  • simapp/CHANGELOG.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
simapp/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🔇 Additional comments (1)
simapp/CHANGELOG.md (1)

1-22: LGTM! Well-structured changelog guidelines.

The header section follows the Keep a Changelog standard and provides clear guidance for contributors.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! The solution to this is actually to link the simapp/CHANGELOG.md from the release/v0.52.branch in the upgrading.md, not to re-add it in main

@BabyHalimao
Copy link
Contributor Author

Hey! The solution to this is actually to link the simapp/CHANGELOG.md from the release/v0.52.branch in the upgrading.md, not to re-add it in main

Hi sir, I have updated the link to https://github.com/cosmos/cosmos-sdk/blob/release/v0.52.x/simapp/CHANGELOG.md

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1615459 and 7cb8574.

📒 Files selected for processing (1)
  • UPGRADING.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
UPGRADING.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

@@ -62,7 +62,7 @@ It is additional to the changes described here.

In this section we describe the changes made in Cosmos SDK' SimApp.
**These changes are directly applicable to your application wiring.**
Please read this section first, but for an exhaustive list of changes, refer to the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/main/simapp/CHANGELOG.md).
Please read this section first, but for an exhaustive list of changes, refer to the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/release/v0.52.x/simapp/CHANGELOG.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix dead link to SimApp CHANGELOG

The link to simapp/CHANGELOG.md is broken as the file was removed in PR #23009. Since this section discusses important changes in SimApp that are directly applicable to application wiring, consider either:

  1. Restoring the CHANGELOG file with the relevant information, or
  2. Including the important changes directly in this section of the upgrade guide.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienrbrt julienrbrt added this pull request to the merge queue Dec 23, 2024
@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Dec 23, 2024
Merged via the queue into cosmos:main with commit 2596c7f Dec 23, 2024
67 checks passed
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
Co-authored-by: Hieu Vu <[email protected]>
(cherry picked from commit 2596c7f)

# Conflicts:
#	UPGRADING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants