-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: v2 services helpers and demo using x/bank
#23057
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
// WithGas sets the gas config and meter on a testing ctx and returns the updated ctx. | ||
func (t TestContext) WithGas(gasConfig gas.GasConfig, gasMeter gas.Meter) TestContext { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created the TestContext wrapper so that we can extend with methods to modify it like the ones here
|
||
type TestEnvironment struct { | ||
env appmodulev2.Environment | ||
memEventsService MemEventsService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the concrete types of our Mem
services so that we can use the additional helper methods (such as GetEvents
) in our tests
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
var ErrNoHandler = errors.New("no handler") | ||
|
||
// NewMsgRouterBuilder is a router that routes messages to their respective handlers. | ||
func NewMsgRouterBuilder() *ReflectionRouterBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core-only router builder that uses reflect
instead of protoreflect for test pathfinding
"context" | ||
"errors" | ||
"fmt" | ||
"reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note test
for msgType, handler := range b.handlers { | ||
// find pre handler | ||
preHandlers := b.preHandlers[msgType] | ||
// find post handler | ||
postHandlers := b.postHandlers[msgType] | ||
// build the handler | ||
handlers[msgType] = buildHandler(handler, preHandlers, globalPreHandler, postHandlers, globalPostHandler) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning test
Description
Part of: #22903
core testing
package to return more services and aTestContext
andTestEnvironment
wrapper that can be used throughout module and keeper-level testsx/bank
test, removing all uses ofbaseapp
andsdk.Context
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...