-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync changelogs #22992
chore: sync changelogs #22992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (31)
x/protocolpool/CHANGELOG.md (1)
28-30
: Enhance the changelog entry with more detailsThe changelog entry for introducing a new module should:
- Be categorized under appropriate sections (Features, API Breaking Changes, etc.)
- Include the PR reference (feat(x/protocolpool,x/distribution)!: remove dependency + fix continuous fund bug #20790) for the BeginBlock addition
- Provide more details about the module's purpose and functionality
Example structure:
## [v0.2.0-rc.1](https://github.com/cosmos/cosmos-sdk/releases/tag/x/protocolpool/v0.2.0-rc.1) - 2024-12-18 ### Features * [#20790] Introduce the `x/protocolpool` module with its own BeginBlock * <Add brief description of module's purpose> ### API Breaking Changes * <List any breaking changes if applicable>x/consensus/CHANGELOG.md (1)
Line range hint
37-40
: Maintain consistent PR reference formattingPlease maintain consistency in PR references:
- Add module prefix
(x/consensus)
to the second feature entry- Keep consistent format for PR references (include parentheses for module name)
Example:
* (x/consensus) [#19483](https://github.com/cosmos/cosmos-sdk/pull/19483) Add consensus messages registration to consensus module. - * [#20615](https://github.com/cosmos/cosmos-sdk/pull/20615) Add consensus messages to add cometinfo to consensus modules + * (x/consensus) [#20615](https://github.com/cosmos/cosmos-sdk/pull/20615) Add consensus messages to add cometinfo to consensus modulesx/circuit/CHANGELOG.md (1)
37-38
: Add module prefix to API Breaking Changes entryPlease add the module prefix for consistency with other entries:
- * [#19041](https://github.com/cosmos/cosmos-sdk/pull/19041) `appmodule.Environment` is received on the Keeper to get access to different application services + * (x/circuit) [#19041](https://github.com/cosmos/cosmos-sdk/pull/19041) `appmodule.Environment` is received on the Keeper to get access to different application servicesx/nft/CHANGELOG.md (1)
34-35
: Add consistent line spacing between version header and sectionsAdd a single blank line between the version header and the first section for consistency with other entries in the changelog.
x/mint/CHANGELOG.md (2)
28-29
: Add consistent line spacing between version header and sectionsAdd a single blank line between the version header and the first section for consistency with other entries in the changelog.
Line range hint
38-42
: Clarify the impact of API breaking changesThe deprecation notice should explicitly mention the migration path for existing users. Consider adding a brief example or more detailed migration instructions.
🧰 Tools
🪛 LanguageTool
[style] ~37-~37: Consider a shorter alternative to avoid wordiness.
Context: ...per.DefaultMintFnwrapper must be used in order to continue using it in
NewAppModule`. Th...(IN_ORDER_TO_PREMIUM)
x/group/CHANGELOG.md (3)
28-29
: Add consistent line spacing between version header and sectionsAdd a single blank line between the version header and the first section for consistency with other entries in the changelog.
Line range hint
33-34
: Fix PR reference formattingThe PR reference
[18286]
is missing the#
prefix. Update to[#18286]
for consistency with other entries.
Line range hint
33-34
: Enhance clarity of the improvement entryThe entry "Move prefix store creation down after error checks" could be more descriptive about the impact and benefits of this change.
x/slashing/CHANGELOG.md (2)
Line range hint
34-34
: Fix grammatical errorChange "
NewAppModule
now takes in acore/comet.Service
an argument" to "NewAppModule
now takes in acore/comet.Service
as an argument"
51-51
: Add newline at end of fileAdd a newline character at the end of the file to comply with markdown standards.
🧰 Tools
🪛 Markdownlint (0.37.0)
51-51: null
Files should end with a single newline character(MD047, single-trailing-newline)
x/evidence/CHANGELOG.md (1)
34-34
: Fix grammatical errorChange "
NewAppModule
now takes in acore/comet.Service
an argument" to "NewAppModule
now takes in acore/comet.Service
as an argument"x/authz/CHANGELOG.md (1)
42-42
: Fix typo in word "address"Change "adress codecs" to "address codecs"
x/bank/CHANGELOG.md (1)
28-29
: Add release status informationConsider adding a note indicating whether this is a pre-release or release candidate version, as this helps users understand the stability expectations.
x/feegrant/CHANGELOG.md (2)
36-36
: Fix grammatical issue in feature descriptionAdd a comma after "file" for better readability:
-The `x/feegrant` module is extracted to have a separate go.mod file which allows it to be a standalone module. +The `x/feegrant` module is extracted to have a separate go.mod file, which allows it to be a standalone module.🧰 Tools
🪛 LanguageTool
[uncategorized] ~36-~36: Possible missing comma found.
Context: ... is extracted to have a separate go.mod file which allows it to be a standalone modu...(AI_HYDRA_LEO_MISSING_COMMA)
41-42
: Improve formatting consistency in API Breaking ChangesConsider using consistent bullet point indentation for better readability. The sub-bullets should align with the text above.
x/upgrade/CHANGELOG.md (2)
Line range hint
39-39
: Enhance state machine breaking change descriptionThe state machine breaking change description should include more context about the impact of moving app version storage to baseapp's ParamStore. Consider adding:
- Migration implications
- Any required actions from users
28-28
: Ensure consistent changelog formatting across modulesWhile all changelogs follow the same template, consider standardizing:
- Section ordering (e.g., Features, Improvements, Bug Fixes, API Breaking Changes)
- Bullet point indentation
- Description style and length
Also applies to: 28-28, 28-28
x/auth/CHANGELOG.md (2)
26-26
: Fix grammatical error: "it's" should be "its"The possessive form "its" should be used instead of the contraction "it's" (which means "it is").
-While x/auth has not been extracted from the Cosmos SDK, it's changelog is maintained here for consistency with the rest of the modules. +While x/auth has not been extracted from the Cosmos SDK, its changelog is maintained here for consistency with the rest of the modules.🧰 Tools
🪛 LanguageTool
[grammar] ~26-~26: Did you mean to use the possessive pronoun “its”?
Context: ...not been extracted from the Cosmos SDK, it's changelog is maintained here for consis...(IT_S_ITS)
67-67
: Remove orphaned line numberThere appears to be an orphaned line number in the middle of the changelog which should be removed for better readability.
x/distribution/CHANGELOG.md (2)
28-28
: Standardize version number formatThe version number format should be consistent across all modules. Consider aligning with the format used in other modules.
Line range hint
71-71
: Remove reverted change noteThe strikethrough text about the
PoolKeeper
argument should be removed since it was reverted in PR #20790.x/gov/CHANGELOG.md (1)
Line range hint
31-38
: Consider consistent formatting in Features sectionEach feature entry should start with a verb (Add, Introduce, etc.) for consistency.
x/staking/CHANGELOG.md (1)
30-32
: Enhance metadata feature descriptionThe metadata feature description could be more detailed about what information can be stored and its purpose.
core/CHANGELOG.md (1)
39-42
: Consider adding explicit version informationWhile noting that v1.0.0 is identical to v1.0.0-alpha.6 is correct, consider adding:
- The release date
- A brief summary of key changes from the alpha version
CHANGELOG.md (3)
238-238
: Fix inconsistent line referencesThere appear to be duplicate line numbers (238 and 1208) in the changelog entries. This could cause confusion when referencing specific changes.
Consider fixing the line numbering to ensure each entry has a unique line reference.
Also applies to: 1208-1208
1156-1160
: Improve formatting consistency in module entriesThe module entries in these lines have inconsistent bullet point formatting:
- * (x/mint) [#12363](https://github.com/cosmos/cosmos-sdk/pull/12363) Migrate `x/mint` to self-managed parameters and deprecate its usage of `x/params`. - * (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) Migrate `x/distribution` to self-managed parameters and deprecate its usage of `x/params`. - * (x/crisis) [#12445](https://github.com/cosmos/cosmos-sdk/pull/12445) Migrate `x/crisis` to self-managed parameters and deprecate its usage of `x/params`. - * (x/gov) [#12631](https://github.com/cosmos/cosmos-sdk/pull/12631) Migrate `x/gov` to self-managed parameters and deprecate its usage of `x/params`.Consider standardizing the bullet point format and removing the line numbers between entries for better readability.
Line range hint
1-50
: Add version comparison tableFor better usability, consider adding a version comparison table at the top of the changelog that summarizes major changes between versions. This would help users quickly identify which version contains the features they need.
Example format:
| Version | Major Features | Breaking Changes | Minimum Go Version | |---------|---------------|------------------|-------------------| | v0.47.0 | Feature A, B | Change X, Y | 1.18 | | v0.46.0 | Feature C, D | Change Z | 1.17 |x/params/CHANGELOG.md (1)
27-27
: Consider removing empty Unreleased sectionThe Unreleased section is empty. Consider removing it if there are no unreleased changes to track.
x/accounts/defaults/base/CHANGELOG.md (2)
28-28
: Fix typo in changelog messageThere's a typo in the changelog message: "Inital" should be "Initial".
-Inital release of the `x/accounts/defaults/base` module. +Initial release of the `x/accounts/defaults/base` module.🧰 Tools
🪛 Markdownlint (0.37.0)
28-28: null
Files should end with a single newline character(MD047, single-trailing-newline)
28-28
: Add newline at end of fileAdd a newline character at the end of the file to comply with markdown formatting standards.
🧰 Tools
🪛 Markdownlint (0.37.0)
28-28: null
Files should end with a single newline character(MD047, single-trailing-newline)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (27)
CHANGELOG.md
(7 hunks)client/v2/CHANGELOG.md
(1 hunks)core/CHANGELOG.md
(1 hunks)tools/benchmark/CHANGELOG.md
(1 hunks)tools/confix/CHANGELOG.md
(1 hunks)x/accounts/CHANGELOG.md
(1 hunks)x/accounts/defaults/base/CHANGELOG.md
(1 hunks)x/accounts/defaults/lockup/CHANGELOG.md
(1 hunks)x/accounts/defaults/multisig/CHANGELOG.md
(1 hunks)x/auth/CHANGELOG.md
(2 hunks)x/authz/CHANGELOG.md
(2 hunks)x/bank/CHANGELOG.md
(1 hunks)x/circuit/CHANGELOG.md
(1 hunks)x/consensus/CHANGELOG.md
(1 hunks)x/distribution/CHANGELOG.md
(1 hunks)x/epochs/CHANGELOG.md
(1 hunks)x/evidence/CHANGELOG.md
(1 hunks)x/feegrant/CHANGELOG.md
(1 hunks)x/gov/CHANGELOG.md
(1 hunks)x/group/CHANGELOG.md
(1 hunks)x/mint/CHANGELOG.md
(1 hunks)x/nft/CHANGELOG.md
(1 hunks)x/params/CHANGELOG.md
(1 hunks)x/protocolpool/CHANGELOG.md
(1 hunks)x/slashing/CHANGELOG.md
(2 hunks)x/staking/CHANGELOG.md
(2 hunks)x/upgrade/CHANGELOG.md
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- x/accounts/defaults/lockup/CHANGELOG.md
- x/accounts/defaults/multisig/CHANGELOG.md
- x/epochs/CHANGELOG.md
- tools/benchmark/CHANGELOG.md
- tools/confix/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (22)
x/protocolpool/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/consensus/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/circuit/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
core/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/nft/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/upgrade/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/auth/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
client/v2/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/authz/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/distribution/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/staking/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/feegrant/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/bank/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/mint/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/group/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/slashing/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/gov/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/evidence/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/accounts/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/accounts/defaults/base/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
x/params/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
x/auth/CHANGELOG.md
[grammar] ~26-~26: Did you mean to use the possessive pronoun “its”?
Context: ...not been extracted from the Cosmos SDK, it's changelog is maintained here for consis...
(IT_S_ITS)
x/feegrant/CHANGELOG.md
[uncategorized] ~36-~36: Possible missing comma found.
Context: ... is extracted to have a separate go.mod file which allows it to be a standalone modu...
(AI_HYDRA_LEO_MISSING_COMMA)
x/accounts/CHANGELOG.md
[typographical] ~28-~28: Unpaired symbol: '[' seems to be missing
Context: ...ngelog ## [Unreleased] ## [v0.2.0-rc.1](https://github.com/cosmos/cosmos-sdk/re...
(UNPAIRED_BRACKETS)
[typographical] ~30-~30: Unpaired symbol: '[' seems to be missing
Context: ...nts/v0.2.0-rc.1) - 2024-12-18 * [#19988](https://github.com/cosmos/cosmos-sdk/pu...
(UNPAIRED_BRACKETS)
x/params/CHANGELOG.md
[typographical] ~28-~28: Unpaired symbol: '[' seems to be missing
Context: ...ngelog ## [Unreleased] ## [v0.2.0-rc.1](https://github.com/cosmos/cosmos-sdk/re...
(UNPAIRED_BRACKETS)
🪛 Markdownlint (0.37.0)
x/slashing/CHANGELOG.md
51-51: null
Files should end with a single newline character
(MD047, single-trailing-newline)
x/accounts/defaults/base/CHANGELOG.md
28-28: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🔇 Additional comments (4)
client/v2/CHANGELOG.md (1)
39-39
: LGTM!
The changelog is well-structured, follows semantic versioning, and maintains consistent formatting across all entries.
x/gov/CHANGELOG.md (1)
28-29
: LGTM: Version entry properly formatted
The version entry follows the standard format with proper link and date.
CHANGELOG.md (1)
Line range hint 1-1261
: Documentation structure and organization is well maintained
The changelog follows good documentation practices with:
- Clear version sections with dates
- Categorized changes (Features, Improvements, Bug Fixes, etc.)
- Links to relevant PRs and issues
- Breaking changes clearly marked
x/accounts/CHANGELOG.md (1)
28-30
: LGTM! Well-structured changelog entry
The changelog entry follows the proper format with:
- Clear version and date
- PR reference
- Concise description of the change
🧰 Tools
🪛 LanguageTool
[typographical] ~28-~28: Unpaired symbol: '[' seems to be missing
Context: ...ngelog ## [Unreleased] ## [v0.2.0-rc.1](https://github.com/cosmos/cosmos-sdk/re...
(UNPAIRED_BRACKETS)
[typographical] ~30-~30: Unpaired symbol: '[' seems to be missing
Context: ...nts/v0.2.0-rc.1) - 2024-12-18 * [#19988](https://github.com/cosmos/cosmos-sdk/pu...
(UNPAIRED_BRACKETS)
Description
Follow-up from rcs + prepare core v1 final.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
API Breaking Changes
Documentation