chore: prepare systemtests release #22658
Conversation
📝 WalkthroughWalkthroughThis pull request includes updates to the changelog, modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
tests/systemtests/go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
systemtests/CHANGELOG.md(1 hunks)systemtests/go.mod(7 hunks)tests/systemtests/getting_started.md(0 hunks)tests/systemtests/go.mod(7 hunks)
💤 Files with no reviewable changes (1)
- tests/systemtests/getting_started.md
✅ Files skipped from review due to trivial changes (1)
- systemtests/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
tests/systemtests/go.mod (1)
Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
🔇 Additional comments (5)
systemtests/go.mod (3)
Line range hint 1-169: LGTM! Dependencies are well-organized for the systemtests release
The dependency updates and reorganization align well with the PR objectives. The changes maintain a clear structure with appropriate versioning.
158-158: Verify Google API dependencies compatibility with gRPC
The genproto package versions should be compatible with grpc v1.68.0.
Also applies to: 159-159, 160-160, 161-161
✅ Verification successful
Let's verify the dependencies and their versions in the local repository first, as the GitHub API search wasn't successful. This will help us understand the exact versions being used together.
Dependencies are compatible with gRPC v1.68.0
The dependency versions are aligned and compatible:
- Using google.golang.org/grpc v1.68.0 with google.golang.org/protobuf v1.35.2
- The genproto packages are using recent versions from 2024, which is appropriate for the gRPC version
- All related protobuf dependencies (gogo/protobuf, golang/protobuf) are at stable versions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check compatibility between genproto packages and grpc
# Check if these specific versions are commonly used together
gh api search/code -f query='path:go.mod "google.golang.org/grpc v1.68.0"' | jq -r '.items[].path' | xargs -I {} gh api repos/{}/contents/go.mod | jq -r '.content' | base64 -d | grep -E 'genproto|protobuf'
Length of output: 397
Script:
#!/bin/bash
# Let's check the current versions in go.mod
cat systemtests/go.mod | grep -E "grpc|genproto|protobuf"
# Also check go.sum for exact versions
cat systemtests/go.sum | grep -E "google.golang.org/genproto.*240227224415" | sort -u
Length of output: 982
9-9: Verify compatibility between cosmos-sdk v0.50.6 and grpc v1.68.0
The update to these core dependencies requires verification of compatibility.
Also applies to: 14-14
✅ Verification successful
No compatibility issues between cosmos-sdk v0.50.6 and grpc v1.68.0
The update to grpc v1.68.0 is compatible with cosmos-sdk v0.50.6 as both are direct dependencies in the same module without any conflicting version constraints or replace directives. The grpc version is also recent enough to support all features required by the SDK.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any known compatibility issues between cosmos-sdk and grpc versions
# Check if cosmos-sdk v0.50.6 mentions specific grpc version requirements
gh api repos/cosmos/cosmos-sdk/contents/go.mod?ref=v0.50.6 | jq -r '.content' | base64 -d | grep 'google.golang.org/grpc'
# Check for any issues mentioning compatibility between these versions
gh search issues "repo:cosmos/cosmos-sdk grpc v1.68.0 is:issue"
Length of output: 507
Script:
#!/bin/bash
# Let's try a different approach to check compatibility
# Check the current go.mod file for grpc version
rg "google.golang.org/grpc" systemtests/go.mod -A 1 -B 1
# Check if there are any direct references to grpc in the codebase that might indicate version requirements
rg "grpc\." --type go
# Look for any version constraints or requirements in go.mod
cat systemtests/go.mod
Length of output: 101520
Script:
#!/bin/bash
# Let's check the go.mod file content and search for grpc version requirements
cat systemtests/go.mod | grep -A 5 -B 5 "google.golang.org/grpc"
# Check if there are any specific version constraints in the cosmos-sdk dependency
cat systemtests/go.mod | grep -A 5 -B 5 "cosmos/cosmos-sdk"
# Look for any replace directives that might affect versioning
cat systemtests/go.mod | grep -A 1 "replace"
Length of output: 814
tests/systemtests/go.mod (2)
1-9: Verify the systemtests dependency version
The systemtests dependency is using a pseudo-version (v0.0.0-20241126144654-14d98d277124). Since this PR is preparing for a release, consider updating it to a proper release version.
✅ Verification successful
The pseudo-version for systemtests dependency is appropriate
The systemtests module appears to be in transition, with evidence of both old (cosmossdk.io/systemtests) and new (github.com/cosmos/cosmos-sdk/tests/systemtests) module paths. Using a pseudo-version is correct in this context since:
- The module is being migrated as part of the release preparation
- No official release tags exist yet
- The package is actively being restructured
The pseudo-version ensures proper dependency tracking during this transition period until an official release is made.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if there are any tagged releases for systemtests
gh api repos/cosmos/cosmos-sdk/tags --jq '.[].name' | grep systemtests
# Check the commit hash to verify it's the latest
git log -1 14d98d2771244c6e23375022f46277657a4776c9 --pretty=format:"%H"
Length of output: 72
Script:
#!/bin/bash
# Let's try a different approach to check the systemtests module and its versioning
# Check if systemtests is a separate module
fd -t f go.mod | xargs cat | grep "module.*systemtests"
# Check for any references to systemtests versions in the codebase
rg -i "systemtests.*v\d+\.\d+\.\d+" --type go
# Look for any systemtests package declarations
ast-grep --pattern 'package systemtests'
Length of output: 1713
44-48: Verify compatibility of cosmos ecosystem dependencies
The new cosmos ecosystem dependencies have been added:
- cosmos-proto is on a beta version (v1.0.0-beta.5)
- gogogateway v1.2.0
- gogoproto v1.7.0
- iavl v1.1.4
Please ensure these versions are compatible with each other and with the cosmos-sdk v0.50.6.
✅ Verification successful
Let me analyze the compatibility of the cosmos ecosystem dependencies based on the search results.
Based on the search results and previous findings, I can now provide a final assessment of the dependencies.
Dependencies are compatible with cosmos-sdk ecosystem
The added dependencies are well-aligned with the cosmos ecosystem:
- cosmos-proto v1.0.0-beta.5 is widely used across cosmos modules as shown in the search results
- gogogateway v1.2.0 is a stable release used consistently across modules
- gogoproto v1.7.0 is the latest version and was officially bumped in the SDK (changelog build(deps): Bump github.com/cosmos/gogoproto from 1.4.10 to 1.7.0 #21295)
- iavl v1.1.4 is compatible with the SDK's requirements
The beta version of cosmos-proto is not a concern as it's a standard dependency in the cosmos ecosystem and is used consistently across multiple core modules.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any reported compatibility issues in go.mod files
rg -A 5 "cosmos-proto.*beta.5|gogogateway.*1.2.0|gogoproto.*1.7.0|iavl.*1.1.4" | grep -B 5 "// indirect"
# Look for any compatibility requirements in README or docs
fd -t f -e md | xargs rg "compatibility|requires"
Length of output: 67938
Script:
#!/bin/bash
# Check for cosmos-sdk version and its dependencies in go.mod files
rg -A 5 "cosmos-sdk.*v0.50|cosmos-sdk.*v0.53" go.mod
# Check for any reported issues or compatibility notes in CHANGELOG files
fd -t f -e md | xargs rg "cosmos-proto.*beta|gogogateway.*1.2.0|gogoproto.*1.7.0|iavl.*1.1.4.*breaking"
Length of output: 259
| @@ -63,7 +45,11 @@ require ( | |||
| github.com/cometbft/cometbft-db v0.14.1 // indirect | |||
| github.com/cosmos/btcutil v1.0.5 // indirect | |||
| github.com/cosmos/cosmos-db v1.0.3-0.20240829004618-717cba019b33 // indirect | |||
| github.com/cosmos/cosmos-proto v1.0.0-beta.5 // indirect | |||
There was a problem hiding this comment.
💡 Codebase verification
Dependency version misalignment detected
The following version mismatches were found between systemtests/go.mod and cosmos-sdk v0.50.6:
- gogoproto: v1.7.0 vs v1.4.12
- iavl: v1.1.4 vs v1.1.2
The cosmos-proto and gogogateway versions are aligned correctly.
Please update the indirect dependencies to match the versions used in cosmos-sdk v0.50.6 to avoid potential compatibility issues.
🔗 Analysis chain
Verify alignment of cosmos infrastructure dependencies
The added cosmos-related indirect dependencies should align with cosmos-sdk v0.50.6.
Also applies to: 50-50, 51-51, 52-52
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify version alignment of cosmos infrastructure dependencies
# Check cosmos-sdk v0.50.6 requirements for these packages
gh api repos/cosmos/cosmos-sdk/contents/go.mod?ref=v0.50.6 | jq -r '.content' | base64 -d | grep -E 'cosmos-proto|gogogateway|gogoproto|iavl'
Length of output: 240
Script:
#!/bin/bash
# Let's try a different approach using ripgrep to check the versions in go.mod files
rg -A 3 "cosmos-sdk.*v0\.50\.6" --type go
# Also check the specific versions of cosmos-proto and other dependencies
rg "cosmos-proto.*v[0-9]" --type go
rg "gogoproto.*v[0-9]" --type go
rg "iavl.*v[0-9]" --type go
Length of output: 2344
Script:
#!/bin/bash
# Let's check the actual content of the go.mod files to see the dependency versions
cat systemtests/go.mod
# Also check if there are any other go.mod files that might contain these dependencies
fd go.mod --exec cat {}
Length of output: 110733
Script:
#!/bin/bash
# Let's check the direct dependencies in the cosmos-sdk v0.50.6 repository
curl -s https://raw.githubusercontent.com/cosmos/cosmos-sdk/v0.50.6/go.mod | grep -E "cosmos-proto|gogogateway|gogoproto|iavl"
Length of output: 292
Description
Small follow-up of 14d98d2
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
v1.0.0-rc.1.go.modfor both system tests and tests.