-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Minor changes on slashing logs and gov Querier #2259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fedekunze -- I left some feedback on how I think the logs could change slightly. Otherwise, LGTM 👍
Codecov Report
@@ Coverage Diff @@
## develop #2259 +/- ##
==========================================
Coverage ? 63.88%
==========================================
Files ? 140
Lines ? 8694
Branches ? 0
==========================================
Hits ? 5554
Misses ? 2758
Partials ? 382 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor thing @fedekunze -- thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK -- attempt a merge of develop
@fedekunze to resolve any CI issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Part 2 of the split process from #2139.
This one adds constants to queriers and has minor changes to logs for better readability.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #Reviewed
Files changed
in the github PR explorerFor Admin Use: