Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log): add slog-backed Logger type #22347
feat(log): add slog-backed Logger type #22347
Changes from 3 commits
f7caf7b
cf20016
a078c39
c3b59df
8f1f86e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add parameter validation in constructor.
The constructor should validate that the input logger is not nil to prevent potential panics.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 cc @mark-rushakoff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julienrbrt, glad you agree!
(_/)
(•ᴗ•)
(")_(")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider validating key-value pairs in logging methods.
The logging methods accept variadic key-value pairs but don't validate that they come in pairs.
Add a helper function for validation:
Then use it in each method, for example:
func (l Logger) Info(msg string, keyVals ...any) { + validateKeyVals(keyVals...) l.log.Info(msg, keyVals...) }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation in With method.
The With method should also validate key-value pairs.
func (l Logger) With(keyVals ...any) log.Logger { + validateKeyVals(keyVals...) return Logger{log: l.log.With(keyVals...)} }