test: migrate e2e/genutil to systemtest #22325
+92
−234
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| //go:build system_test | ||
|
|
||
| package systemtests | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "github.com/tidwall/gjson" | ||
| ) | ||
|
|
||
| func TestExportCmd_WithHeight(t *testing.T) { | ||
| sut.ResetChain(t) | ||
| cli := NewCLIWrapper(t, sut, verbose) | ||
|
|
||
| sut.StartChain(t) | ||
|
|
||
| // Wait 10s for producing blocks | ||
| time.Sleep(10 * time.Second) | ||
|
Comment on lines
+22
to
+23
There was a problem hiding this comment. Replace hard-coded sleep with deterministic block height check Using Example implementation: -// Wait 10s for producing blocks
-time.Sleep(10 * time.Second)
+// Wait for chain to produce some blocks
+require.Eventually(t, func() bool {
+ height, err := sut.QueryCurrentHeight()
+ return err == nil && height >= 5
+}, 30*time.Second, 100*time.Millisecond)
|
||
|
|
||
| sut.StopChain() | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| args []string | ||
| expZeroHeight bool | ||
| }{ | ||
| {"should export correct height", []string{"genesis", "export", "--home", sut.nodePath(0)}, false}, | ||
| {"should export correct height with --height", []string{"genesis", "export", "--height=5", "--home", sut.nodePath(0), "--log_level=disabled"}, false}, | ||
| {"should export height 0 with --for-zero-height", []string{"genesis", "export", "--for-zero-height=true", "--home", sut.nodePath(0)}, true}, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| res := cli.RunCommandWithArgs(tc.args...) | ||
| height := gjson.Get(res, "initial_height").Int() | ||
| if tc.expZeroHeight { | ||
| require.Equal(t, height, int64(0)) | ||
| } else { | ||
| require.Greater(t, height, int64(0)) | ||
| } | ||
|
|
||
| // Check consensus params of exported state | ||
| maxGas := gjson.Get(res, "consensus.params.block.max_gas").Int() | ||
| require.Equal(t, maxGas, int64(MaxGas)) | ||
| } | ||
| } | ||
|
|
||
| func TestExportCmd_WithFileFlag(t *testing.T) { | ||
| sut.ResetChain(t) | ||
| cli := NewCLIWrapper(t, sut, verbose) | ||
| exportFile := "foobar.json" | ||
|
|
||
| sut.StartChain(t) | ||
|
|
||
| // Wait 10s for producing blocks | ||
| time.Sleep(10 * time.Second) | ||
|
|
||
| sut.StopChain() | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| args []string | ||
| expErr bool | ||
| errMsg string | ||
| }{ | ||
| {"invalid home dir", []string{"genesis", "export", "--home=foo"}, true, "no such file or directory"}, | ||
| {"should export state to the specified file", []string{"genesis", "export", fmt.Sprintf("--output-document=%s", exportFile), "--home", sut.nodePath(0)}, false, ""}, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| if tc.expErr { | ||
| assertOutput := func(_ assert.TestingT, gotErr error, gotOutputs ...interface{}) bool { | ||
| require.Contains(t, gotOutputs[0], tc.errMsg) | ||
| return false | ||
| } | ||
| cli.WithRunErrorMatcher(assertOutput).RunCommandWithArgs(tc.args...) | ||
| } else { | ||
| cli.RunCommandWithArgs(tc.args...) | ||
| require.FileExists(t, exportFile) | ||
| err := os.Remove(exportFile) | ||
| require.NoError(t, err) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Direct usage of
github.com/spf13/cobradetectedThe
github.com/spf13/cobradependency is still directly used in the codebase. Please review the dependency status to ensure it is correctly marked as indirect.🔗 Analysis chain
Verify the indirect status of github.com/spf13/cobra
The
github.com/spf13/cobradependency is now marked as indirect. This suggests that it's no longer directly used in the code but is still required by other dependencies. Please verify that this change is intentional and doesn't affect any functionality.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 55686