refactor(server/v2): late bound storeBuilder #22206
Conversation
kocubinski
requested review from
julienrbrt,
hieuvubk and
a team
as code owners
📝 WalkthroughWalkthroughThe changes in this pull request involve significant updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (2)
- server/v2/store/commands.go (3 hunks)
- server/v2/store/snapshot.go (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
server/v2/store/commands.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/store/snapshot.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (2)
server/v2/store/snapshot.go (1)
42-42: LGTM: Simplified createRootStore callThe change to
createRootStorealigns with the PR objective of simplifying the configuration process. The removal of thedbparameter suggests that the root store creation has been refactored to use theviperinstance for configuration.To ensure consistency across the codebase, let's verify other calls to
createRootStore:✅ Verification successful
Verified:
createRootStoreusage is consistent across the codebase.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other occurrences of createRootStore to ensure consistent usage rg --type go 'createRootStore\(' --glob '!server/v2/store/snapshot.go'Length of output: 282
server/v2/store/commands.go (1)
78-87: Improved function implementation looks goodThe refactored
createRootStorefunction simplifies the code by removing unnecessary parameters and streamlining the configuration handling. The implementation follows best practices and enhances maintainability.
| rootStore, opts, err := createRootStore(vp, logger) | ||
| if err != nil { | ||
| return fmt.Errorf("can not create root store %w", err) |
There was a problem hiding this comment.
Correct spelling of 'cannot' in error message
The error message should use 'cannot' instead of 'can not' as per standard English usage.
Apply this diff to correct the spelling:
return fmt.Errorf("can not create root store %w", err)
+return fmt.Errorf("cannot create root store %w", err)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| rootStore, opts, err := createRootStore(vp, logger) | |
| if err != nil { | |
| return fmt.Errorf("can not create root store %w", err) | |
| rootStore, opts, err := createRootStore(vp, logger) | |
| if err != nil { | |
| return fmt.Errorf("cannot create root store %w", err) |
| diff := latestHeight - opts.SCPruningOption.KeepRecent | ||
| cmd.Printf("pruning heights up to %v\n", diff) |
There was a problem hiding this comment.
Handle potential negative 'diff' value
If opts.SCPruningOption.KeepRecent is greater than latestHeight, the calculated diff will be negative, which may not make sense in the context of pruning. Consider adding a check to ensure that diff is not negative before proceeding.
Consider adding the following check:
+if diff <= 0 {
+ cmd.Println("No heights to prune")
+ return nil
+}
diff := latestHeight - opts.SCPruningOption.KeepRecent
cmd.Printf("pruning heights up to %v\n", diff)Committable suggestion was skipped due to low confidence.
Description
Any reason we can't just use StoreBuilder here? It simplifies the config story a bit.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes