Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate e2e/auth to system tests and fix sign-batch #22149

Merged
merged 16 commits into from
Oct 11, 2024
Merged

test: migrate e2e/auth to system tests and fix sign-batch #22149

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9eb792a
WIP: auth system tests
akhilkumarpilli Oct 1, 2024
74690c0
add signTx Tests
akhilkumarpilli Oct 3, 2024
1912932
add more tests
akhilkumarpilli Oct 7, 2024
c84048d
Merge branch 'main' into akhil/auth-system-tests
akhilkumarpilli Oct 8, 2024
e87276b
add multisig setup
akhilkumarpilli Oct 8, 2024
9408091
add multisign tx tests
akhilkumarpilli Oct 9, 2024
72facec
add remaining tests
akhilkumarpilli Oct 10, 2024
188e94a
Merge branch 'main' into akhil/auth-system-tests
akhilkumarpilli Oct 10, 2024
8deed48
delete relevant tests
akhilkumarpilli Oct 10, 2024
fd94d8e
fix lint
akhilkumarpilli Oct 10, 2024
a9f74cd
fix system test
akhilkumarpilli Oct 10, 2024
e2a6ae3
update mock account retriever
akhilkumarpilli Oct 11, 2024
6d04bb7
fix lint
akhilkumarpilli Oct 11, 2024
37a1331
Merge branch 'main' into akhil/auth-system-tests
akhilkumarpilli Oct 11, 2024
18dc0cb
add build tag
akhilkumarpilli Oct 11, 2024
e8b13be
assert valid cases aux signer
akhilkumarpilli Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions client/account_retriever.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,26 @@ type Account interface {
GetSequence() uint64
}

type mockAccount struct {
addr []byte
}

func (m mockAccount) GetAddress() sdk.AccAddress {
return m.addr
}

func (m mockAccount) GetPubKey() cryptotypes.PubKey {
return nil
}

func (m mockAccount) GetAccountNumber() uint64 {
return 0
}

func (m mockAccount) GetSequence() uint64 {
return 0
}
Comment on lines +24 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider making mock values configurable

The implementation of GetPubKey, GetAccountNumber, and GetSequence methods is correct for a basic mock. However, to enhance flexibility in testing scenarios, consider making these values configurable. This would allow tests to set specific values when needed.

Here's a suggested implementation:

type mockAccount struct {
	address []byte
	pubKey  cryptotypes.PubKey
	accNum  uint64
	seq     uint64
}

func (m mockAccount) GetPubKey() cryptotypes.PubKey {
	return m.pubKey
}

func (m mockAccount) GetAccountNumber() uint64 {
	return m.accNum
}

func (m mockAccount) GetSequence() uint64 {
	return m.seq
}

This change would require updating the MockAccountRetriever.GetAccount method to initialize these fields.


// AccountRetriever defines the interfaces required by transactions to
// ensure an account exists and to be able to query for account fields necessary
// for signing.
Expand All @@ -32,8 +52,8 @@ type MockAccountRetriever struct {
ReturnAccNum, ReturnAccSeq uint64
}

func (mar MockAccountRetriever) GetAccount(_ Context, _ sdk.AccAddress) (Account, error) {
return nil, nil
func (mar MockAccountRetriever) GetAccount(_ Context, address sdk.AccAddress) (Account, error) {
return mockAccount{addr: address}, nil
}

func (mar MockAccountRetriever) GetAccountWithHeight(_ Context, _ sdk.AccAddress) (Account, int64, error) {
Expand Down
20 changes: 0 additions & 20 deletions tests/e2e/auth/cli_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading