-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update upgrade docs #22105
docs: Update upgrade docs #22105
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on enhancing the documentation for the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use a tag (v0.52.0-beta.1) instead of the release branch to prevent it to channge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
x/upgrade/README.md (2)
318-338
: LGTM! New 'authority' CLI command well-documented.The new 'authority' CLI command is a valuable addition, allowing users to query the address authorized for upgrade proposals. The documentation is clear and includes a helpful example.
Consider adding a brief note about the significance of this authority address to provide more context for users.
351-354
: Approved: Improved naming for 'cancel-upgrade-proposal' command.The renaming of 'cancel-software-upgrade' to 'cancel-upgrade-proposal' enhances consistency and clarity in the CLI commands.
For complete consistency, consider renaming 'software-proposal' to 'upgrade-proposal' in the previous example (not shown in this diff).
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- x/upgrade/README.md (8 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/upgrade/README.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🔇 Additional comments (3)
x/upgrade/README.md (3)
492-512
: LGTM! New REST endpoint for querying authority address.The new '/cosmos/upgrade/v1beta1/authority' endpoint is a welcome addition, providing a RESTful way to query the authorized address for upgrade proposals. The documentation is clear and includes a helpful example.
554-554
: Approved: Simplified gRPC examples for better readability.The gRPC examples for 'CurrentPlan' and 'ModuleVersions' have been streamlined, improving readability while maintaining functionality. The consistent format across examples is appreciated.
Also applies to: 576-576
652-672
: LGTM! New gRPC endpoint for querying authority address.The new 'cosmos.upgrade.v1beta1.Query/Authority' gRPC endpoint is a valuable addition, providing a gRPC method to query the authorized address for upgrade proposals. The documentation is clear and includes a helpful example, maintaining consistency with the CLI and REST implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
(cherry picked from commit 69914dc)
Description
ref: #21429
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
authority
for querying the authorized address for upgrade proposals./cosmos/upgrade/v1beta1/authority
for similar functionality.cosmos.upgrade.v1beta1.Query/Authority
for accessing upgrade information.Improvements
cancel-upgrade-proposal
for clarity.