Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/v2/comebft): wire missing services + fix simulation #21964

Merged
merged 29 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6e59fbb
feat(server/v2/comebft): fix simulation wiring
julienrbrt Sep 27, 2024
19debfe
updates
julienrbrt Sep 27, 2024
9aba7af
Merge branch 'main' into julien/fix-simulate
julienrbrt Oct 8, 2024
e6c8460
updates
julienrbrt Oct 8, 2024
edde74d
Merge branch 'main' into julien/fix-simulate
julienrbrt Oct 9, 2024
daf2ea5
Merge branch 'main' into julien/fix-simulate
julienrbrt Oct 15, 2024
420220e
Merge branch 'main' into julien/fix-simulate
julienrbrt Oct 27, 2024
b550b90
Merge branch 'main' into julien/fix-simulate
julienrbrt Nov 5, 2024
a15551e
wip
julienrbrt Nov 5, 2024
4f54f1c
Merge branch 'main' into julien/fix-simulate
julienrbrt Nov 8, 2024
7f707dc
Merge branch 'main' into julien/fix-simulate
julienrbrt Nov 8, 2024
e81317a
Merge branch 'main' into julien/fix-simulate
julienrbrt Nov 11, 2024
9315b59
wire nodeservice
julienrbrt Nov 11, 2024
e15a675
simplify
julienrbrt Nov 11, 2024
6fcfead
updates
julienrbrt Nov 13, 2024
5dc9e8e
Merge branch 'main' into julien/fix-simulate
julienrbrt Nov 18, 2024
1722c18
tidy
julienrbrt Nov 18, 2024
28c7ddf
updates
julienrbrt Nov 18, 2024
c67a32e
simulate
julienrbrt Nov 18, 2024
5e55ce8
updates
julienrbrt Nov 18, 2024
b995dbd
remove scrums of previous app closer
julienrbrt Nov 18, 2024
5bbd256
implement nodeservice v1beta1 by comet
julienrbrt Nov 18, 2024
f33fe9e
meh
julienrbrt Nov 18, 2024
d3e7082
`make lint-fix`
julienrbrt Nov 18, 2024
765bd57
`make lint-fix`
julienrbrt Nov 18, 2024
eb78af6
updates
julienrbrt Nov 18, 2024
3f6c19b
tpo
julienrbrt Nov 18, 2024
c7d65a8
Merge branch 'main' into julien/fix-simulate
julienrbrt Nov 18, 2024
c86df3a
feedback
julienrbrt Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,093 changes: 2,093 additions & 0 deletions api/cosmos/base/node/v2/query.pulsar.go

Large diffs are not rendered by default.

167 changes: 167 additions & 0 deletions api/cosmos/base/node/v2/query_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions client/grpc/cmtservice/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ type (

// NewQueryServer creates a new CometBFT query server.
func NewQueryServer(
clientCtx CometRPC,
cometRPC CometRPC,
queryFn abciQueryFn,
consensusAddressCodec address.Codec,
) ServiceServer {
return queryServer{
rpc: clientCtx,
rpc: cometRPC,
queryFn: queryFn,
consensusCodec: consensusAddressCodec,
}
Expand Down Expand Up @@ -284,7 +284,7 @@ func (s queryServer) ABCIQuery(ctx context.Context, req *ABCIQueryRequest) (*ABC
func RegisterTendermintService(
clientCtx client.Context,
server gogogrpc.Server,
iRegistry codectypes.InterfaceRegistry,
_ codectypes.InterfaceRegistry,
queryFn abciQueryFn,
) {
node, err := clientCtx.GetNode()
Expand Down
39 changes: 39 additions & 0 deletions proto/cosmos/base/node/v2/query.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
syntax = "proto3";
package cosmos.base.node.v2;

import "google/api/annotations.proto";
import "google/protobuf/timestamp.proto";
import "gogoproto/gogo.proto";

option go_package = "cosmossdk.io/server/v2/api/grpc/nodeservice";

// Service defines the gRPC querier service for node related queries.
service Service {
// Config queries for the operator configuration.
rpc Config(ConfigRequest) returns (ConfigResponse) {
option (google.api.http).get = "/cosmos/base/node/v2/config";
}
// Status queries for the node status.
rpc Status(StatusRequest) returns (StatusResponse) {
option (google.api.http).get = "/cosmos/base/node/v2/status";
}
}

// ConfigRequest defines the request structure for the Config gRPC query.
message ConfigRequest {}

// ConfigResponse defines the response structure for the Config gRPC query.
message ConfigResponse {
string minimum_gas_price = 1;
}

// StatusRequest defines the request structure for the status of a node.
message StatusRequest {}

// StatusResponse defines the response structure for the status of a node.
message StatusResponse {
uint64 height = 1; // current block height
google.protobuf.Timestamp timestamp = 2 [(gogoproto.stdtime) = true]; // block height timestamp
bytes app_hash = 3; // app hash of the current block
bytes validator_hash = 4; // validator hash provided by the consensus header
}
Loading
Loading