fix(systemtest): upgrade test

[alpe]

Description

Bump halt height in upgrade test. See #21256 for context

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the upgrade process to halt the chain at a height one greater than before, improving upgrade timing and conditions.

[coderabbitai]

Walkthrough

Walkthrough

The pull request modifies the TestChainUpgrade function in the upgrade_test.go file by changing the argument for the sut.StartChain method. The --halt-height parameter is updated from upgradeHeight to upgradeHeight + 1, which alters the chain's halt height during the upgrade process.

Changes

File	Change Summary
tests/systemtests/upgrade_test.go	Modified TestChainUpgrade to adjust --halt-height from upgradeHeight to upgradeHeight + 1.

Sequence Diagram(s)

sequenceDiagram
    participant SUT as System Under Test
    participant Chain as Blockchain

    SUT->>Chain: StartChain(--halt-height=upgradeHeight + 1)
    Chain-->>SUT: Chain started with new halt height

Loading

---

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e6b1bbc and aeea373.

Files selected for processing (1)

• tests/systemtests/upgrade_test.go (1 hunks)

Additional context used

Path-based instructions (1)

tests/systemtests/upgrade_test.go (3)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

---

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (2)

tests/systemtests/upgrade_test.go (2)

41-41: Approved: Adjustment improves upgrade test accuracy

The change to halt the chain one block after the upgrade height (upgradeHeight + 1) is a good improvement. This modification ensures that the upgrade is fully processed before the chain halts, allowing the test to capture the state immediately after the upgrade. This aligns well with the PR objective to adjust the halt height in the upgrade test.

---

Line range hint 1-124: Overall test coverage and code style are satisfactory

The TestChainUpgrade function provides comprehensive coverage of the chain upgrade process, including:

1. Starting a legacy chain
2. Submitting and voting on an upgrade proposal
3. Waiting for the upgrade height
4. Verifying the chain's functionality post-upgrade

The test structure and implementation adhere to the Uber Golang style guide. The coverage appears sufficient for the changes associated with this pull request.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

@Mergifyio backport release/v0.52.x

[mergify]

backport release/v0.52.x

✅ Backports have been created

• #21879 fix(systemtest): upgrade test (backport #21877) has been created for branch release/v0.52.x