Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): use address codec for tx.Sign #21436

Merged
merged 3 commits into from
Aug 28, 2024
Merged

feat(client): use address codec for tx.Sign #21436

merged 3 commits into from
Aug 28, 2024

Conversation

julienrbrt
Copy link
Member

Description

Closes: #21430

We can use a client.Context in tx.Sign as it contains an address codec.
The change is minimally breaking as we always have a client.Context available when using tx.Sign and client.Context contains as well the command context.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Aug 28, 2024
@julienrbrt julienrbrt requested a review from a team as a code owner August 28, 2024 07:49
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024 •
edited
Loading

Warning

Rate limit exceeded

@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 6 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4c796d2 and 1491288.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@julienrbrt julienrbrt mentioned this pull request Aug 28, 2024
Closed
JulianToledano
JulianToledano approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@JulianToledano JulianToledano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hieuvubk
hieuvubk approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@hieuvubk hieuvubk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt enabled auto-merge August 28, 2024 08:00
@julienrbrt julienrbrt added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 01abf4f Aug 28, 2024
74 checks passed
@julienrbrt julienrbrt deleted the julien/address-codec-sign branch August 28, 2024 08:19
mergify bot pushed a commit that referenced this pull request Aug 28, 2024
@julienrbrt @mergify
feat(client): use address codec for tx.Sign (#21436)
876c7d4 
(cherry picked from commit 01abf4f)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Aug 28, 2024
Merged
12 tasks
julienrbrt added a commit that referenced this pull request Aug 28, 2024
@mergify @julienrbrt
feat(client): use address codec for tx.Sign (backport #21436) (#21437)
49bcd45 
Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieuvubk hieuvubk hieuvubk approved these changes

@JulianToledano JulianToledano JulianToledano approved these changes

Assignees

@JulianToledano JulianToledano

@hieuvubk hieuvubk

Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:CLI C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: supporting chains with different prefix
3 participants
@julienrbrt @JulianToledano @hieuvubk