Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/gov): Backport of pull request #18173 to feature/v.0.47.x-ics-lsm branch #19305

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix(x/gov): Backport of pull request #18173 to feature/v.0.47.x-ics-lsm branch #19305

merged 1 commit into from
Feb 1, 2024

Conversation

dusan-maksimovic
Copy link

Description

Backport of PR #18173: Introduce & handle errors returned by the gov module hooks

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@dusan-maksimovic dusan-maksimovic requested a review from a team as a code owner January 31, 2024 10:02
@dusan-maksimovic dusan-maksimovic marked this pull request as draft January 31, 2024 10:10
@dusan-maksimovic dusan-maksimovic marked this pull request as ready for review January 31, 2024 12:14
MSalopek
MSalopek approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dusan-maksimovic Thanks!

LGTM

mpoke
mpoke approved these changes Feb 1, 2024
View reviewed changes
Copy link

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @dusan-maksimovic

@mpoke mpoke merged commit f6bf231 into cosmos:feature/v0.47.x-ics-lsm Feb 1, 2024
22 of 25 checks passed
mattverse pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 6, 2024
@dusan-maksimovic @mattverse
fix(x/gov): Backport of pull request cosmos#18173 to feature/v.0.47.x…
3168764 
…-ics-lsm branch (cosmos#19305)
@mattverse mattverse mentioned this pull request Feb 6, 2024
Merged
19 tasks
czarcas7ic added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 9, 2024
@mattverse @dusan-maksimovic @czarcas7ic
(Backport) fix(x/gov): let hooks return an error (#514)
c2363b6 
* fix(x/gov): Backport of pull request cosmos#18173 to feature/v.0.47.x-ics-lsm branch (cosmos#19305)

* update changelog

---------

Co-authored-by: Dusan Maksimovic <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@mpoke mpoke mpoke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusan-maksimovic @mpoke @MSalopek