Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): Implement LookupMap #18933

Merged
merged 11 commits into from
Jan 30, 2024
Merged

feat(collections): Implement LookupMap #18933

merged 11 commits into from
Jan 30, 2024

Conversation

likhita-809
Copy link
Contributor

Description

ref: #18732


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@likhita-809 likhita-809 marked this pull request as ready for review January 19, 2024 09:49
@likhita-809 likhita-809 requested a review from a team as a code owner January 19, 2024 09:49
Copy link
Contributor

coderabbitai bot commented Jan 19, 2024

Walkthrough

The update introduces a new data structure called LookupMap, which is a non-iterable map. This map comes with a set of methods for creation, data manipulation, and access control, including setting and getting values, checking key existence, and key removal. Additionally, the update includes a suite of tests to ensure the functionality of the LookupMap, such as verifying key presence, manipulating key-value pairs, and removing keys.

Changes

File(s) Change Summary
collections/lookup_map.go, collections/lookup_map_test.go Introduces LookupMap type representing a non-iterable map with associated methods and corresponding tests.
collections/map.go Updates error formatting to use multi error wrapping in go1.20.
collections/CHANGELOG.md Added a new feature by introducing LookupMap implementation and a Vec collection type.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

This comment has been minimized.

collections/lookup_map_test.go Show resolved Hide resolved
collections/lookup_map.go Outdated Show resolved Hide resolved
collections/lookup_map.go Show resolved Hide resolved
@likhita-809
Copy link
Contributor Author

@julienrbrt can you have a final look on this PR? So that it can be merged faster

@likhita-809
Copy link
Contributor Author

reminding for final review @julienrbrt

collections/lookup_map.go Outdated Show resolved Hide resolved
@likhita-809 likhita-809 added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 30, 2024
@@ -33,6 +33,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* [#18933](https://github.com/cosmos/cosmos-sdk/pull/18933) Add LookupMap implementation. It is basic wrapping of the standard Map methods but is not iterable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry for LookupMap correctly follows the prescribed format, including the tag, issue reference, and a concise description. However, consider enhancing the description to briefly mention the significance or use case of LookupMap being non-iterable, providing more context to the reader.

@julienrbrt julienrbrt added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 639735d Jan 30, 2024
56 of 61 checks passed
@julienrbrt julienrbrt deleted the likhita/18732 branch January 30, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:collections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants