-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Speedup DecCoin.Sort() when coins is of length 1 #18888
Conversation
Warning Rate Limit Exceeded@DongLieu has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 12 minutes and 54 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
(cherry picked from commit de4c9e7) # Conflicts: # CHANGELOG.md
(cherry picked from commit de4c9e7) # Conflicts: # CHANGELOG.md
…) (#18889) Co-authored-by: Dong Lieu <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…) (#18890) Co-authored-by: Dong Lieu <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…os#18888) (cosmos#18890) Co-authored-by: Dong Lieu <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…os#18888) (cosmos#18890) Co-authored-by: Dong Lieu <[email protected]> Co-authored-by: marbar3778 <[email protected]>
Similar to PR #18875, I think that we should avoid this heap allocation if len(coins) <= 1.