-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/auth): remove misleading gas wanted value from tx simulation failure response #18772
Conversation
We were puzzled by the huge gas wanted value logged by simulation failure, thought we made some mistake in tx building, but actually it's not the gas wanted set in the tx, but due to an `InfinitGasMeter` is set in simulation mode bypassing the input gas limit, which makes the `gasInfo.GasWanted` to be `MaxUint64`. So I suggest we don't output this value here at all.
WalkthroughThe recent changes involve the removal of misleading information regarding 'gas wanted' from the transaction simulation failure logs. This adjustment was made to ensure that the error messages are clear and do not provide unnecessary or incorrect data that could confuse users during transaction simulation errors. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
…ilure response (#18772) Co-authored-by: Aleksandr Bezobchuk <[email protected]> (cherry picked from commit e0b1675) # Conflicts: # CHANGELOG.md
…ilure response (#18772) Co-authored-by: Aleksandr Bezobchuk <[email protected]> (cherry picked from commit e0b1675) # Conflicts: # CHANGELOG.md
…ilure response (backport #18772) (#18775) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…ilure response (backport #18772) (#18776) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…ilure response (backport cosmos#18772) (cosmos#18776) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…ilure response (backport cosmos#18772) (cosmos#18776) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]>
We were puzzled by the huge gas wanted value output in the simulation failure response (
With gas wanted: '18446744073709551615' and gas used: '318310'
), thought we made some mistake in building the tx, but actually it's not the gas wanted we set in the tx, but due to anInfinitGasMeter
is set in simulation mode bypassing the tx gas limit, which makes theGasWanted
to beMaxUint64
.We suggest to remove this misleading value from the response.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...