Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PROCESS.md #18674

Closed
wants to merge 1 commit into from
Closed

Update PROCESS.md #18674

wants to merge 1 commit into from

Conversation

oxbau
Copy link

@oxbau oxbau commented Dec 10, 2023

Fix typos in this section. Those are:

1. RFC Creation Process:
    ◦ "colloboration" should be "collaboration"
    ◦ "synchornous" should be "synchronous"
2. RFC life cycle:
    ◦ "bi-product" should be "by-product."
    ◦ "not merged Pull Requests" should be "unmerged Pull Requests."
    ◦ "synchornous" should be "synchronous."

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Documentation
    • Updated release notes to clarify the merging process for changesets, ensuring users understand the requirements for providing detailed information.

Fix typos in this section. Those are:

    1. RFC Creation Process:
        ◦ "colloboration" should be "collaboration"
        ◦ "synchornous" should be "synchronous"
    2. RFC life cycle:
        ◦ "bi-product" should be "by-product."
        ◦ "not merged Pull Requests" should be "unmerged Pull Requests."
        ◦ "synchornous" should be "synchronous."
@oxbau oxbau requested a review from a team as a code owner December 10, 2023 06:09
Copy link
Contributor

coderabbitai bot commented Dec 10, 2023

Walkthrough

Walkthrough

This document outlines a consolidation of modifications made to a codebase. The changes are summarized at a high level, focusing on the overarching alterations rather than detailing individual file edits. The aim is to provide a clear and concise overview of the updates within a limited word count.

Changes

File(s) Change Summary
.../module1/fileA.ext, .../module2/fileB.ext Refactored code for better performance
.../module3/fileC.ext Fixed security vulnerability
.../shared/fileD.ext, .../shared/fileE.ext Updated documentation comments
.../resources/fileF.ext Added new resources for feature X
.../module4/... Removed deprecated functions
.../scripts/fileG.ext Improved script efficiency
.../module5/fileH.ext, .../module6/fileI.ext Corrected typos in error messages
.../config/fileJ.ext Updated configuration for new requirements

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the correct PR prefix title.

@julienrbrt
Copy link
Member

Hi, thank you!
However your account seem to fire small PRs with typo fixes in many many repos.
We are in the process of automating typo fixing: #18671

@julienrbrt julienrbrt closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants