fix(snapshot): grant execution permissions to the snapshot dir for the owner #18294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent changes primarily focus on enhancing the security and accessibility of the snapshot feature. The permissions for the snapshot directory have been modified to allow execution by the owner, thereby ensuring better control and functionality. Changes
TipsChat with CodeRabbit Bot (
|
github-prbot
requested review from
a team,
kocubinski and
samricotta
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
julienrbrt
approved these changes
Oct 29, 2023
CHANGELOG.md
Outdated
| @@ -76,6 +76,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * (x/gov) [#17873](https://github.com/cosmos/cosmos-sdk/pull/17873) Fail any inactive and active proposals whose messages cannot be decoded. | |||
| * (simulation) [#17911](https://github.com/cosmos/cosmos-sdk/pull/17911) Fix all problems with executing command `make test-sim-custom-genesis-fast` for simulation test. | |||
| * (simulation) [#18196](https://github.com/cosmos/cosmos-sdk/pull/18196) Fix the problem of `validator set is empty after InitGenesis` in simulation test. | |||
| * (snapshot) [#18294](https://github.com/cosmos/cosmos-sdk/pull/18294) Grant execution permissions to the snapshot dir for the owner. | |||
There was a problem hiding this comment.
Suggested change
| * (snapshot) [#18294](https://github.com/cosmos/cosmos-sdk/pull/18294) Grant execution permissions to the snapshot dir for the owner. |
No changelog needed as this regression never been released (#18206)
julienrbrt
added
backport/v0.47.x
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
…e owner (#18294) Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit a378303)
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
…e owner (#18294) Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit a378303)
atheeshp
pushed a commit
that referenced
this pull request
Nov 1, 2023
…e owner (#18294) Co-authored-by: Julien Robert <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #18206 , the permissions of snapshot dir were modified. However, in my macos sonoma 14, when executing simd start --home ./nodes/node0/simd the following error occurred: panic: failed to initialize database: stat nodes/node0/simd /data/snapshots/metadata.db: permission denied. The main reason is lack of execute permissions for the owner.
In addition, search for the keyword os.MkdirAll in the project, and the owner will have executable permissions.
Summary by CodeRabbit