Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authz): check string is not empty #18209

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(authz): check string is not empty #18209

merged 1 commit into from
Oct 23, 2023

Conversation

tac0turtle
Copy link
Member

Description

a-23

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Oct 23, 2023
@tac0turtle tac0turtle marked this pull request as ready for review October 23, 2023 11:27
@tac0turtle tac0turtle requested a review from a team as a code owner October 23, 2023 11:27
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team October 23, 2023 11:29
@github-actions
Copy link
Contributor

@tac0turtle your pull request is missing a changelog!

julienrbrt
julienrbrt approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@tac0turtle tac0turtle enabled auto-merge October 23, 2023 13:24
@tac0turtle tac0turtle added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 19eaac3 Oct 23, 2023
51 of 52 checks passed
@tac0turtle tac0turtle deleted the marko/a-23 branch October 23, 2023 13:47
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@tac0turtle @mergify
fix(authz): check string is not empty (#18209)
c62ebb8 
(cherry picked from commit 19eaac3)

# Conflicts:
#	x/authz/generic_authorization.go
@mergify mergify bot mentioned this pull request Oct 23, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@tac0turtle @mergify
fix(authz): check string is not empty (#18209)
f8665d9 
(cherry picked from commit 19eaac3)

# Conflicts:
#	x/authz/generic_authorization.go
@mergify mergify bot mentioned this pull request Oct 23, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Oct 23, 2023
@mergify @tac0turtle
fix(authz): check string is not empty (backport #18209) (#18218)
269a245 
Co-authored-by: Marko <[email protected]>
julienrbrt pushed a commit that referenced this pull request Oct 23, 2023
@mergify @tac0turtle
fix(authz): check string is not empty (backport #18209) (#18217)
aa72f10 
Co-authored-by: Marko <[email protected]>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica facundomedica approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@facundomedica facundomedica

@julienrbrt julienrbrt

Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/authz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @facundomedica @julienrbrt