-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): start grpc server and register services in standalone mode #18110
feat(server): start grpc server and register services in standalone mode #18110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need the api server here as well?
Currently I don't. I'll let you decide whether you think this should still be started - I think the alternative is to have an issue for it and pick it back up if anyone asks for it at some point |
can we add a startAPI call, everything seems registered, for consistency and to avoid have another issue sitting for a while |
Done, it's also starting the api server now |
…ode (#18110) Co-authored-by: Marko <[email protected]> (cherry picked from commit 31f5bc0) # Conflicts: # CHANGELOG.md
Description
Closes: #16277
Starts the gRPC server even when standalone mode is used.
Also registers services to expose over the gRPC server:
The CometBFT rpc endpoin t is assumed to be exposed at the rpc.laddr (which is where the cometBFT server started by the SDK would also expose the rpc server).
I tried this locally with CometMock and it fixes #16277: I tried grpcurl to call endpoints from
cosmos.tx.v1beta1.Service
,cosmos.base.node.v1beta1.Service/Status
andcosmos.base.tendermint.v1beta1.Service
Is there any testing infrastructure set up to test out-of-process comet?
Then tests for this could hook in there.
If there are no tests for that anyways, I think this change isn't necessarily worth adding them for,
since it's relatively minimal.
This should be backported to v0.47 and v0.50. There is already a PR that aims to backport to v0.47 here:
#18109
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change