Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check for nil params (backport #18041) #18069

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 11, 2023

This is an automatic backport of pull request #18041 done by Mergify.
Cherry-pick of ed14ec0 has failed:

On branch mergify/bp/release/v0.47.x/pr-18041
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit ed14ec03b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   x/consensus/keeper/keeper.go
	both modified:   x/consensus/keeper/keeper_test.go
	both modified:   x/consensus/types/msgs.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Co-authored-by: atheeshp <[email protected]>
(cherry picked from commit ed14ec0)

# Conflicts:
#	CHANGELOG.md
#	x/consensus/keeper/keeper.go
#	x/consensus/keeper/keeper_test.go
#	x/consensus/types/msgs.go
@mergify mergify bot requested a review from a team as a code owner October 11, 2023 10:23
@mergify mergify bot added the conflicts label Oct 11, 2023
tac0turtle
tac0turtle previously approved these changes Oct 11, 2023
@tac0turtle tac0turtle dismissed their stale review October 11, 2023 14:02

panicing here wouldnt be good

@tac0turtle tac0turtle self-assigned this Oct 11, 2023
@@ -42,6 +44,10 @@
}

func (msg MsgUpdateParams) ToProtoConsensusParams() tmproto.ConsensusParams {
if msg.Evidence == nil || msg.Block == nil || msg.Validator == nil {
panic(errors.New("all parameters must be present"))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@julienrbrt julienrbrt merged commit d24d469 into release/v0.47.x Oct 11, 2023
25 of 26 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.47.x/pr-18041 branch October 11, 2023 19:38
@faddat faddat mentioned this pull request Mar 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants