Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(staking): add delegator to events #18006

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore(staking): add delegator to events #18006

merged 1 commit into from
Oct 9, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Oct 9, 2023
@tac0turtle tac0turtle marked this pull request as ready for review October 9, 2023 10:07
@tac0turtle tac0turtle requested a review from a team as a code owner October 9, 2023 10:07
@github-prbot github-prbot requested review from a team, samricotta and atheeshp and removed request for a team October 9, 2023 10:07
@tac0turtle tac0turtle added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit b170ccc Oct 9, 2023
49 of 50 checks passed
@tac0turtle tac0turtle deleted the marko/staking_events branch October 9, 2023 11:30
mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@tac0turtle @mergify
chore(staking): add delegator to events (#18006)
b1daac7 
(cherry picked from commit b170ccc)
mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@tac0turtle @mergify
chore(staking): add delegator to events (#18006)
1be4ec3 
(cherry picked from commit b170ccc)

# Conflicts:
#	x/staking/keeper/msg_server.go
This was referenced Oct 9, 2023
Merged
Merged
julienrbrt added a commit that referenced this pull request Oct 9, 2023
@mergify @tac0turtle @julienrbrt
chore(staking): add delegator to events (backport #18006) (#18012)
2601e23 
Co-authored-by: Marko <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
julienrbrt pushed a commit that referenced this pull request Oct 9, 2023
@mergify @tac0turtle
chore(staking): add delegator to events (backport #18006) (#18011)
b0d20bc 
Co-authored-by: Marko <[email protected]>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@samricotta samricotta Awaiting requested review from samricotta

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @julienrbrt