Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(baseapp): expose Mempool #17954

Merged
merged 2 commits into from
Oct 9, 2023
Merged

feat(baseapp): expose Mempool #17954

merged 2 commits into from
Oct 9, 2023

Conversation

itsdevbear
Copy link
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@itsdevbear itsdevbear requested a review from a team as a code owner October 4, 2023 13:55
@github-prbot github-prbot requested review from a team, kocubinski and julienrbrt and removed request for a team October 4, 2023 14:01
julienrbrt
julienrbrt approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but curious about your use case.
Additionally, can you add a changelog under unreleased improvements? This is something we can backport all the way down to v0.47.

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Oct 4, 2023
@alexanderbez
Copy link
Contributor

Second @julienrbrt's question. What's the exact use-case (not that I'm against it). Given that the app sets the mempool, you should have access to it at some point in the stack, no?

@itsdevbear
Copy link
Contributor Author

@alexanderbez @julienrbrt

we have to set the client context from the server on our mempool. Just prevents from having to store another pointer to it on our app.

@itsdevbear
Copy link
Contributor Author

nothing wild haha

@julienrbrt
Copy link
Member

👍🏾—Can we still get a changelog? :)

@julienrbrt
Copy link
Member

I'll add the changelog in the backport of v0.47.

@julienrbrt julienrbrt added this pull request to the merge queue Oct 9, 2023
Merged via the queue into cosmos:main with commit 68a136b Oct 9, 2023
46 of 48 checks passed
mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@itsdevbear @mergify
feat(baseapp): expose Mempool (#17954)
074052e 
(cherry picked from commit 68a136b)
mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@itsdevbear @mergify
feat(baseapp): expose Mempool (#17954)
e88539f 
(cherry picked from commit 68a136b)

# Conflicts:
#	baseapp/baseapp.go
This was referenced Oct 9, 2023
Merged
Merged
julienrbrt pushed a commit that referenced this pull request Oct 9, 2023
@mergify @itsdevbear
feat(baseapp): expose Mempool (backport #17954) (#18009)
ef5c356 
Co-authored-by: Devon Bear <[email protected]>
julienrbrt added a commit that referenced this pull request Oct 9, 2023
@mergify @itsdevbear @julienrbrt
feat(baseapp): expose Mempool (backport #17954) (#18010)
7d12782 
Co-authored-by: Devon Bear <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees

@alexanderbez alexanderbez

@julienrbrt julienrbrt

Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsdevbear @alexanderbez @julienrbrt @tac0turtle