-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): PreBlocker getting overwritten if set as a baseapp option #17944
Conversation
is this a blocker for 0.50 |
Yes, it is already set here, and we should have an if-check to verify that it isn't already set in baseapp. |
@facundomedica your pull request is missing a changelog! |
We might have to do the same for Begin/EndBlock depending on use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Agree to not have this in module level, as it quite complexify the API and may lead to some hacky things done by modules. |
…on (backport #17944) (#18046) Co-authored-by: Facundo Medica <[email protected]>
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change