Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): PreBlocker getting overwritten if set as a baseapp option #17944

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

facundomedica
Copy link
Member

Description


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 3, 2023
@tac0turtle
Copy link
Member

is this a blocker for 0.50

@julienrbrt
Copy link
Member

is this a blocker for 0.50

Yes, it is already set here, and we should have an if-check to verify that it isn't already set in baseapp.

@facundomedica facundomedica marked this pull request as ready for review October 10, 2023 09:59
@facundomedica facundomedica requested a review from a team as a code owner October 10, 2023 09:59
@github-prbot github-prbot requested a review from a team October 10, 2023 09:59
@github-actions
Copy link
Contributor

@facundomedica your pull request is missing a changelog!

@github-prbot github-prbot requested review from kocubinski and samricotta and removed request for a team October 10, 2023 09:59
@facundomedica
Copy link
Member Author

We might have to do the same for Begin/EndBlock depending on use cases.
Also maybe think about passing txs to the modules' PreBlocker that way we wouldn't need a global Preblocker but we could leave that to each module.
On the other hand, PrepareProposal, VoteExtensions and such are part of baseapp and modules can't access that, so the creation of the injected tx we use in VE is being that at a "global" level, so it might not make sense to do it at a module's level.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt
Copy link
Member

Agree to not have this in module level, as it quite complexify the API and may lead to some hacky things done by modules.

@tac0turtle tac0turtle added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 3ac7c0e Oct 10, 2023
48 of 49 checks passed
@tac0turtle tac0turtle deleted the facu/preblock-overwr branch October 10, 2023 14:48
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
julienrbrt pushed a commit that referenced this pull request Oct 10, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants