Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): return accId in error #17903

Merged
merged 2 commits into from
Sep 27, 2023
Merged

chore(auth): return accId in error #17903

merged 2 commits into from
Sep 27, 2023

Conversation

tac0turtle
Copy link
Member

Description

A-21

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Sep 27, 2023
@tac0turtle tac0turtle requested a review from a team as a code owner September 27, 2023 12:06
@github-prbot github-prbot requested review from a team, kocubinski and atheeshp and removed request for a team September 27, 2023 12:06
@julienrbrt julienrbrt added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 6ac0abd Sep 27, 2023
50 checks passed
@julienrbrt julienrbrt deleted the marko/audit_4 branch September 27, 2023 13:00
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
@tac0turtle @mergify
chore(auth): return accId in error (#17903)
7a935d6 
(cherry picked from commit 6ac0abd)
@mergify mergify bot mentioned this pull request Sep 27, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
@tac0turtle @mergify
chore(auth): return accId in error (#17903)
955d8dc 
(cherry picked from commit 6ac0abd)

# Conflicts:
#	x/auth/keeper/grpc_query.go
@mergify mergify bot mentioned this pull request Sep 27, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Sep 27, 2023
@mergify @tac0turtle
chore(auth): return accId in error (backport #17903) (#17905)
f4796c9 
Co-authored-by: Marko <[email protected]>
julienrbrt added a commit that referenced this pull request Sep 27, 2023
@mergify @tac0turtle @julienrbrt
chore(auth): return accId in error (backport #17903) (#17906)
85034c1 
Co-authored-by: Marko <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this pull request Oct 9, 2023
@mergify @tac0turtle
@julienrbrt @mmsqe
chore(auth): return accId in error (backport cosmos#17903) (cosmos#17906
22f68a4 
)

Co-authored-by: Marko <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @julienrbrt