Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store): check value #17900

Merged
merged 1 commit into from
Sep 27, 2023
Merged

chore(store): check value #17900

merged 1 commit into from
Sep 27, 2023

Conversation

tac0turtle
Copy link
Member

Description

A-11


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner September 27, 2023 11:47
@tac0turtle tac0turtle added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Sep 27, 2023
@github-prbot github-prbot requested a review from a team September 27, 2023 11:47
@github-prbot github-prbot requested review from facundomedica and samricotta and removed request for a team September 27, 2023 11:47
@julienrbrt julienrbrt changed the title chore: check value chore(store): check value Sep 27, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 337b3fe Sep 27, 2023
54 checks passed
@julienrbrt julienrbrt deleted the marko/audit_1 branch September 27, 2023 13:12
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
(cherry picked from commit 337b3fe)
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
(cherry picked from commit 337b3fe)
tac0turtle added a commit that referenced this pull request Sep 27, 2023
tac0turtle added a commit that referenced this pull request Sep 27, 2023
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this pull request Oct 9, 2023
@faddat faddat mentioned this pull request Mar 20, 2024
12 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants