refactor(staking): change historicalinfo to contain minimal set of data #17655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
changed the title
damiannolan
reviewed
Sep 7, 2023
tac0turtle
force-pushed
the
marko/reduce_historicalInfo
branch
from
7783a24 to
750a213
Compare
tac0turtle
commented
Sep 18, 2023
github-prbot
requested review from
a team,
kocubinski and
julienrbrt
and removed request for
a team
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
julienrbrt
reviewed
Sep 18, 2023
damiannolan
reviewed
Sep 19, 2023
julienrbrt
reviewed
Sep 19, 2023
CHANGELOG.md
Outdated
| @@ -160,6 +160,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| * (x/distribution) [#17115](https://github.com/cosmos/cosmos-sdk/pull/17115) Migrate `PreviousProposer` to collections. | |||
| * (x/upgrade) [#16244](https://github.com/cosmos/cosmos-sdk/pull/16244) upgrade module no longer stores the app version but gets and sets the app version stored in the `ParamStore` of baseapp. | |||
| * (x/staking) [#17655](https://github.com/cosmos/cosmos-sdk/pull/17655) `HistoricalInfo` was replaced with `Historical`, it removes the validator set and comet header and only keep what is needed for IBC. | |||
There was a problem hiding this comment.
I feel like the changelog does not correspond to the latest updates in this PR.
There was a problem hiding this comment.
Can we add a Client Breaking change as well, given that the response of the query will be different?
julienrbrt
reviewed
Sep 19, 2023
julienrbrt
reviewed
Sep 19, 2023
| @@ -25,6 +25,22 @@ var _ types.ValidatorSet = Keeper{} | |||
| // Implements DelegationSet interface | |||
| var _ types.DelegationSet = Keeper{} | |||
|
|
|||
| func HistoricalInfoCodec(cdc codec.BinaryCodec) collcodec.ValueCodec[types.HistoricalRecord] { | |||
There was a problem hiding this comment.
Nit, should be in keys.go for consistency with bank (
cosmos-sdk/x/bank/types/keys.go
Line 39 in c25ddd3
julienrbrt
changed the title
damiannolan
reviewed
Sep 19, 2023
| message HistoricalRecord { | ||
| bytes apphash = 1; | ||
| google.protobuf.Timestamp time = 2 [(gogoproto.stdtime) = true]; | ||
| bytes validator_hash = 3; |
There was a problem hiding this comment.
Sorry, I know this is just merged, but should this field be validators_hash (plural). I can make a PR if you want :)
20 tasks
12 tasks
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While speaking with the ibc-go team and rereading the adr it became apparent that only three fields are needed by the ibc team and everything else is redundant. This PR aims to remove the redundant code in order to reduce state bloat
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change