refactor(x/staking): Migrate ValidatorQueue to use Collections #17562
Conversation
github-prbot
requested review from
a team,
alexanderbez and
testinginprod
and removed request for
a team
x/staking/keeper/validator.go
Outdated
|
|
||
| bz, err := store.Get(types.GetValidatorQueueKey(endTime, endHeight)) | ||
| timeBz := sdk.FormatTimeBytes(endTime) | ||
| timeBzL := len(timeBz) |
There was a problem hiding this comment.
really unfortunate that we prefix time bytes with their length even when the size is constant and well-known. =(
There was a problem hiding this comment.
you can use here if you want k.ValidatorsQueue.KeyCodec().Size(endTime), instead of using sdk.FormatTimeBytes... At least this way we don't need to rely on format time bytes and we keep it in between collections. I would even comment this in the Keeper why we use three keys instead of using simply two.
There was a problem hiding this comment.
I don't think we can use k.ValidatorQueue.KeyCodec().Size(endTime) because key here should be of format collections.Triple[uint64, time.Time, uint64], not just time(endTime). And it gives size of the combined length of fields in key.
There was a problem hiding this comment.
I mean, it's a good workaround, unfortunate that we had to do it but it works lol. Once we finish up with all these migrations we'll most definitely do a lot of refactor so we can do proper migrations then
There was a problem hiding this comment.
I see, then @likhita-809 maybe we can use sdk.TimeKey.Size directly, sorry for being pedantic about this, but I'd rather we remove every form of bytes conversion in state from production code, testing is fine to have it.
There was a problem hiding this comment.
Although, time key size is constant so in theory we could use the same number everywhere: https://github.com/cosmos/cosmos-sdk/blob/main/types/collections.go#L210
|
@testinginprod this one also needs a final review |
Co-authored-by: unknown unknown <unknown@unknown>
… into likhita/valQueue
Description
Closes: #16391
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change