chore: log panic recovery in runTx #17556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
tac0turtle and
atheeshp
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
807
to
813
| if r := recover(); r != nil { | ||
| recoveryMW := newOutOfGasRecoveryMiddleware(gasWanted, ctx, app.runTxRecoveryMiddleware) | ||
| err, result = processRecovery(r, recoveryMW), nil | ||
| ctx.Logger().Error("panic recovered in runTx", "err", err) | ||
| } | ||
|
|
||
| gInfo = sdk.GasInfo{GasWanted: gasWanted, GasUsed: ctx.GasMeter().GasConsumed()} |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:792)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTx (baseapp/baseapp.go:722)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:658)
alexanderbez
approved these changes
Aug 28, 2023
tac0turtle
approved these changes
Aug 28, 2023
tac0turtle
added
the
backport/v0.50.x
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit cc6511e)
tac0turtle
pushed a commit
that referenced
this pull request
Aug 28, 2023
|
@tac0turtle are we down to back port into 0.50? |
|
it was already |
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Sep 11, 2023
tac0turtle
pushed a commit
that referenced
this pull request
Sep 11, 2023
Co-authored-by: Cal Bera <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for easier debugging when panics occur during tx execution. Willing to change the log message if needed.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change