Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(x/group): fix submit-proposal help json example #17546

Merged
merged 2 commits into from
Aug 25, 2023
Merged

docs(x/group): fix submit-proposal help json example #17546

merged 2 commits into from
Aug 25, 2023

Conversation

fmorency
Copy link
Contributor

Description

Closes: #17545

Fixes the proposal.json example from the submit-proposal CLI help.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@fmorency fmorency requested a review from a team as a code owner August 25, 2023 15:15
@github-prbot github-prbot requested a review from a team August 25, 2023 15:16
@github-prbot github-prbot requested review from tac0turtle and testinginprod and removed request for a team August 25, 2023 15:16
@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Aug 25, 2023
julienrbrt
julienrbrt approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@julienrbrt julienrbrt enabled auto-merge August 25, 2023 15:24
@julienrbrt julienrbrt added this pull request to the merge queue Aug 25, 2023
Merged via the queue into cosmos:main with commit 6b868a1 Aug 25, 2023
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@fmorency @mergify
docs(x/group): fix submit-proposal help json example (#17546)
b285c38 
(cherry picked from commit 6b868a1)
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@fmorency @mergify
docs(x/group): fix submit-proposal help json example (#17546)
f463e2a 
(cherry picked from commit 6b868a1)
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Aug 25, 2023
@mergify @fmorency
docs(x/group): fix submit-proposal help json example (backport #17546) (
992c164 
#17550)

Co-authored-by: Félix C. Morency <[email protected]>
julienrbrt pushed a commit that referenced this pull request Aug 25, 2023
@mergify @fmorency
docs(x/group): fix submit-proposal help json example (backport #17546) (
4bba75e 
#17551)

Co-authored-by: Félix C. Morency <[email protected]>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation]: x/group MsgSubmitProposalCmd proposal.json example is wrong
2 participants
@fmorency @julienrbrt