Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/staking): Migrate LastValidatorPower to Collections #17498

Merged
merged 30 commits into from
Aug 30, 2023
Merged

refactor(x/staking): Migrate LastValidatorPower to Collections #17498

merged 30 commits into from
Aug 30, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16376

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809
remove log
3c103ee
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
0cb3d26 
…ita/lastValPowerKey
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
3c3a788 
…ita/lastValPowerKey
@likhita-809
wip: fix few tests
7a6d3f3
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
467e94d 
…ita/lastValPowerKey
@likhita-809
try fixing test
f20a10f
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
a4371b9 
…ita/lastValPowerKey
@likhita-809
fix lint
c301ee3
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
77f8538 
…ita/lastValPowerKey
@likhita-809
try fixing tests
63e1385
@likhita-809
cleanup
ee4a932
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
629deff 
…ita/lastValPowerKey
@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
8ff06cd 
…ita/lastValPowerKey
@likhita-809 likhita-809 marked this pull request as ready for review August 28, 2023 10:18
@likhita-809 likhita-809 requested a review from a team as a code owner August 28, 2023 10:18
@github-prbot github-prbot requested review from a team, facundomedica and julienrbrt and removed request for a team August 28, 2023 10:18
kocubinski
kocubinski reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@kocubinski kocubinski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the reader of types.LastValidatorPowerKey is updated in this PR, but not the writer. Did I get that right? Is that done in a separate PR?

@likhita-809
Copy link
Contributor Author

I see the reader of types.LastValidatorPowerKey is updated in this PR, but not the writer. Did I get that right? Is that done in a separate PR?

I don't understand. Does the changes for SetLastValidatorPower and DeleteLastValidatorPower not count as writer aspects ?
https://github.com/cosmos/cosmos-sdk/pull/17498/files#diff-2a8f5018500e3fbb8c797d0c094548fc71bc2823bf30924df821a23313a610a3R369
https://github.com/cosmos/cosmos-sdk/pull/17498/files#diff-2a8f5018500e3fbb8c797d0c094548fc71bc2823bf30924df821a23313a610a3R374

facundomedica
facundomedica reviewed Aug 30, 2023
View reviewed changes
x/staking/keeper/alias_functions.go Outdated Show resolved Hide resolved
x/staking/keeper/keeper_test.go Show resolved Hide resolved
x/staking/keeper/val_state_change.go Outdated Show resolved Hide resolved
@kocubinski
Copy link
Member

I see the reader of types.LastValidatorPowerKey is updated in this PR, but not the writer. Did I get that right? Is that done in a separate PR?

I don't understand. Does the changes for SetLastValidatorPower and DeleteLastValidatorPower not count as writer aspects ? https://github.com/cosmos/cosmos-sdk/pull/17498/files#diff-2a8f5018500e3fbb8c797d0c094548fc71bc2823bf30924df821a23313a610a3R369 https://github.com/cosmos/cosmos-sdk/pull/17498/files#diff-2a8f5018500e3fbb8c797d0c094548fc71bc2823bf30924df821a23313a610a3R374

Oh I definitely missed that on my first pass of this PR.

@tac0turtle tac0turtle added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 3e07c80 Aug 30, 2023
@tac0turtle tac0turtle deleted the likhita/lastValPowerKey branch August 30, 2023 21:24
julienrbrt
julienrbrt reviewed Aug 31, 2023
View reviewed changes
x/staking/keeper/keeper.go
@@ -51,6 +51,7 @@ type Keeper struct {
RedelegationsByValDst collections.Map[collections.Triple[[]byte, []byte, []byte], []byte]
RedelegationsByValSrc collections.Map[collections.Triple[[]byte, []byte, []byte], []byte]
UnbondingDelegationByValIndex collections.Map[collections.Pair[[]byte, []byte], []byte]
LastValidatorPower collections.Map[[]byte, []byte]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say that I would find useful if we can add comments next to the field précising what is expected as key and as value. Right now, it is really not clear that we expect until I look deeper in the code.
I believe this would be a good practice to start doing when we simply use byte slices.

@julienrbrt julienrbrt mentioned this pull request Aug 31, 2023
Closed
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
This was referenced May 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@atheeshp atheeshp atheeshp approved these changes

@kocubinski kocubinski kocubinski approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

Assignees

@kocubinski kocubinski

@facundomedica facundomedica

@atheeshp atheeshp

Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(staking): move LastValidatorPower to use collections
6 participants
@likhita-809 @kocubinski @facundomedica @julienrbrt @atheeshp @tac0turtle