refactor(x/staking): migrate ValidatorByConsAddr key to collections
#17260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheeshp
changed the title
ValidatorByConsAddr key to collectionsValidatorByConsAddr key to collections
github-prbot
requested review from
a team,
kocubinski and
julienrbrt
and removed request for
a team
…dk into ap/val-by-cons-addr-coll
julienrbrt
changed the title
ValidatorByConsAddr key to collectionsValidatorByConsAddr key to collections
julienrbrt
reviewed
Aug 3, 2023
|
I agree with Julien's comments, the helper might need to go back. The rest LGTM and it passes the |
julienrbrt
approved these changes
Aug 3, 2023
| @@ -91,12 +91,6 @@ func GetValidatorKey(operatorAddr sdk.ValAddress) []byte { | |||
| return append(ValidatorsKey, address.MustLengthPrefix(operatorAddr)...) | |||
| } | |||
|
|
|||
| // GetValidatorByConsAddrKey creates the key for the validator with pubkey | |||
| // VALUE: validator operator address ([]byte) | |||
| func GetValidatorByConsAddrKey(addr sdk.ConsAddress) []byte { | |||
There was a problem hiding this comment.
We need an API breaking Changes changelog entry for this.
julienrbrt
reviewed
Aug 3, 2023
facundomedica
approved these changes
Aug 3, 2023
12 tasks
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16378
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change