Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove rosetta from repo #17112

Merged
merged 5 commits into from
Jul 24, 2023
Merged

refactor!: remove rosetta from repo #17112

merged 5 commits into from
Jul 24, 2023

Conversation

bizk
Copy link
Contributor

@bizk bizk commented Jul 24, 2023 •
edited
Loading

Description

Closes: #17111

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta Type: Build Type: CI labels Jul 24, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 24, 2023
@julienrbrt
Copy link
Member

Can we get a mention in the UPGRADING.md and CHANGELOG.md that Rosetta has moved location?

@bizk bizk requested a review from julienrbrt July 24, 2023 17:44
@bizk bizk marked this pull request as ready for review July 24, 2023 17:46
@bizk bizk requested review from tac0turtle and a team as code owners July 24, 2023 17:46
@github-prbot github-prbot requested a review from a team July 24, 2023 17:46
julienrbrt
julienrbrt reviewed Jul 24, 2023
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
docs/.gitignore Outdated Show resolved Hide resolved
docs/post.sh Outdated Show resolved Hide resolved
@bizk bizk requested a review from julienrbrt July 24, 2023 18:58
@bizk bizk mentioned this pull request Jul 24, 2023
Closed
julienrbrt
julienrbrt approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

tools/rosetta/sonar-project.properties Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge July 24, 2023 19:12
@julienrbrt julienrbrt changed the title feat: rosetta cleanup refactor!: remove rosetta from repo Jul 24, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cosmos:main with commit 506e87a Jul 24, 2023
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
@bizk @mergify
refactor!: remove rosetta from repo (#17112)
ed0198a 
(cherry picked from commit 506e87a)

# Conflicts:
#	UPGRADING.md
#	contrib/rosetta/rosetta-ci/data.tar.gz
#	simapp/go.mod
#	tools/rosetta/client_online.go
#	tools/rosetta/converter.go
#	tools/rosetta/go.mod
#	tools/rosetta/go.sum
#	tools/rosetta/lib/errors/errors_test.go
@mergify mergify bot mentioned this pull request Jul 24, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 24, 2023
@mergify @bizk @julienrbrt
refactor!: remove rosetta from repo (backport #17112) (#17117)
0cff9ce 
Co-authored-by: Carlos Santiago Yanzon <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@bizk bizk deleted the zondax/feature/rosettaCleanup branch August 15, 2023 14:17
@tkxkd0159 tkxkd0159 mentioned this pull request Jun 12, 2024
Closed
4 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle tac0turtle is a code owner

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Rosetta Issues and PR related to Rosetta Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Rosetta Cleanup
2 participants
@bizk @julienrbrt