refactor(x/slashing): migrate ValidatorSigningInfo to collections #17023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ita/coll-valSignInfo
…ita/coll-valSignInfo
github-prbot
requested review from
a team,
kocubinski and
samricotta
and removed request for
a team
tac0turtle
reviewed
Jul 18, 2023
Comment on lines
+30
to
+31
| Params collections.Item[types.Params] | ||
| ValidatorSigningInfo collections.Map[sdk.ConsAddress, types.ValidatorSigningInfo] |
There was a problem hiding this comment.
random thought but are we able to make these private? params i feel yes since the module can make a query through the router to get the same info
a bit out of scope of this pr but something to think about instead of making it all public
tac0turtle
approved these changes
Jul 18, 2023
…ita/coll-valSignInfo
julienrbrt
changed the title
julienrbrt
reviewed
Jul 18, 2023
simapp/export.go
Outdated
| info.StartHeight = 0 | ||
| err = app.SlashingKeeper.ValidatorSigningInfo.Set(ctx, addr, info) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Why cannot we return the error here? We probably should instead of panicking.
There was a problem hiding this comment.
I thought we are panicking on every error in prepForZeroHeightGenesis. To keep that consistent behaviour I put panic there instead of returning error
There was a problem hiding this comment.
the error is propagated back to err in line 235, so it's fine to error here
atheeshp
approved these changes
Jul 18, 2023
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16362
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change