-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): improve prune
command ux
#16856
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
cmd := &cobra.Command{ | ||
Use: "prune", | ||
Use: "prune [pruning-method]", | ||
Short: "Prune app history states by keeping the recent heights and deleting old heights", | ||
Long: `Prune app history states by keeping the recent heights and deleting old heights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we confirm the output of this displays nicely and is formatted correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a spacing issue, let me fix it.
(cherry picked from commit 317fb0b) # Conflicts: # CHANGELOG.md
(cherry picked from commit 317fb0b) # Conflicts: # CHANGELOG.md # client/pruning/main.go # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go
(cherry picked from commit 317fb0b) # Conflicts: # CHANGELOG.md # client/pruning/main.go # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
…16876) Co-authored-by: Julien Robert <[email protected]>
…16876) Co-authored-by: Julien Robert <[email protected]>
* build(deps): bump cometbft to v0.34.29 (cosmos#16553) * fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570) Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604) Co-authored-by: yihuang <[email protected]> * feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731) Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823) Co-authored-by: KyleMoser <[email protected]> Co-authored-by: HuangYi <[email protected]> * fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876) Co-authored-by: Julien Robert <[email protected]> * fix: query tx events with `>=` and `<=` operators (cosmos#16994) * docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019) * chore: prepare v0.46.14 (cosmos#16879) * refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <[email protected]> --------- Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: KyleMoser <[email protected]> Co-authored-by: Rootul P <[email protected]> Co-authored-by: Devon Bear <[email protected]>
…16876) Co-authored-by: Julien Robert <[email protected]>
Description
Closes: #16855
Right now, passing the home flag is mandatory otherwise it panics. It isn't a great UX, as every other SDK commands do not require to always pass a flag.
Looking as well now how to make the ux for this command better.
In the backport, I'll do it non-breaking for v0.46 and v0.47.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change