Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(math): fix FormatDec test #15215

Merged
merged 1 commit into from
Feb 28, 2023
Merged

test(math): fix FormatDec test #15215

merged 1 commit into from
Feb 28, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 28, 2023

Description

Closes: #15214


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner February 28, 2023 12:38
@github-prbot github-prbot requested review from a team and atheeshp and removed request for a team February 28, 2023 12:38
@julienrbrt julienrbrt changed the title test: fix FormatDec test test(math): fix FormatDec test Feb 28, 2023
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree that it was weird to be importing test data from another package. Also, it didn't show up in the tests in the other PR 🤔

@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 28, 2023

LGTM, agree that it was weird to be importing test data from another package. Also, it didn't show up in the tests in the other PR thinking

Yeah, because CI runs only tests on per diff in a package, which makes sense when not doing importing testdata from somewhere else.
Checked the repo, and it does not happen anywhere else.

@julienrbrt julienrbrt enabled auto-merge (squash) February 28, 2023 14:52
@julienrbrt julienrbrt merged commit 1273c05 into main Feb 28, 2023
@julienrbrt julienrbrt deleted the julien/fix-math-test branch February 28, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatDec test failing on math
2 participants