Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Viper from ante handler #1391

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Remove Viper from ante handler #1391

merged 1 commit into from
Jun 26, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jun 26, 2018 •
edited
Loading

No longer necessary, and confusing.

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes requested a review from ebuchman as a code owner June 26, 2018 21:46
@cwgoes cwgoes requested a review from AdityaSripal June 26, 2018 21:46
@cwgoes cwgoes mentioned this pull request Jun 26, 2018
Merged
4 tasks
@cwgoes cwgoes merged commit 8778576 into develop Jun 26, 2018
@cwgoes cwgoes deleted the cwgoes/remove-viper-from-ante branch June 26, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwgoes @AdityaSripal