Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run make format #13375

Merged
merged 2 commits into from
Sep 23, 2022
Merged

chore: run make format #13375

merged 2 commits into from
Sep 23, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 23, 2022

Description

Just a routine make format before attempting to pull in cosmos-db


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #13375 (5e70860) into main (b10097f) will increase coverage by 1.82%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13375      +/-   ##
==========================================
+ Coverage   54.26%   56.08%   +1.82%     
==========================================
  Files         639      713      +74     
  Lines       54585    60174    +5589     
==========================================
+ Hits        29620    33750    +4130     
- Misses      22583    23665    +1082     
- Partials     2382     2759     +377     
Impacted Files Coverage Δ
depinject/module_key.go 100.00% <ø> (ø)
tx/textual/valuerenderer/coins.go 80.80% <ø> (ø)
orm/encoding/ormfield/timestamp.go 76.31% <0.00%> (ø)
orm/model/ormdb/module.go 63.51% <0.00%> (ø)
cosmovisor/cmd/cosmovisor/help.go 100.00% <0.00%> (ø)
cosmovisor/cmd/cosmovisor/run_config.go 0.00% <0.00%> (ø)
orm/model/ormtable/primary_key.go 49.66% <0.00%> (ø)
depinject/check_type.go 76.31% <0.00%> (ø)
depinject/container.go 90.40% <0.00%> (ø)
... and 67 more

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those PRs!

@julienrbrt julienrbrt merged commit af81605 into cosmos:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants