-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use module permission from app_config in app.go
#12997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12997 +/- ##
==========================================
- Coverage 55.71% 55.64% -0.08%
==========================================
Files 648 644 -4
Lines 54963 54861 -102
==========================================
- Hits 30624 30525 -99
- Misses 21868 21874 +6
+ Partials 2471 2462 -9
|
julienrbrt
force-pushed
the
julien/app-wiring-acc-perms
branch
from
August 22, 2022 21:28
6b9340a
to
ca647fe
Compare
likhita-809
reviewed
Aug 23, 2022
alexanderbez
approved these changes
Aug 23, 2022
I guess this supersedes my PR #13003 which I think we can close. |
alexanderbez
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
app.go
should use the permission from the app config instead of the map. This was a left-over from the legacy app.app_legacy.go
this replicates fix: fix the gov proposals #13002 here inapp_legacy.go
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change