Don't run defers if it would result in an NPE #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
force-pushed
the
dev/fix_defer_close
branch
from
0633ae2 to
61feec6
Compare
ValarDragon
force-pushed
the
dev/fix_defer_close
branch
from
61feec6 to
f1e4cfb
Compare
cwgoes
reviewed
Jun 16, 2018
|
|
||
| BREAKING CHANGES | ||
| * Change default ports from 466xx to 266xx | ||
|
|
||
| FIXES | ||
| * \#1259 - fix bug where certain tests that could have a nil pointer in defer |
There was a problem hiding this comment.
Why the backslash? edit: escape Markdown
|
The lcd tests don't fail on my machine. My system: Over here they're all basically port in use errors. (e.g. listen tcp 0.0.0.0:36658: bind: address already in use) |
Codecov Report
@@ Coverage Diff @@
## develop #1281 +/- ##
========================================
Coverage 65.26% 65.26%
========================================
Files 102 102
Lines 5519 5519
========================================
Hits 3602 3602
Misses 1708 1708
Partials 209 209 |
|
It was some strange circle ci bug earlier. Re ran the tests manually and they all passed! |
cwgoes
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1259. I've checked this on all usages of defer in the sdk.
does this need to update the changelog? I'm not sure.- updated changelog