-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate x/auth/vesting
to use app wiring
#12301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
changed the title
feat: migrate
feat: migrate Jun 18, 2022
vesting
to use app wiringx/auth/vesting
to use app wiring
tac0turtle
reviewed
Jun 18, 2022
julienrbrt
force-pushed
the
julien/vesting-app-wiring
branch
from
June 19, 2022 07:57
311ad4d
to
7580b1c
Compare
Now that we have app wiring, this can happen: #9958 (I wondered why it was a module within auth, turns out there were already an issue for moving it 😄) |
tac0turtle
approved these changes
Jun 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #12301 +/- ##
==========================================
- Coverage 66.13% 66.10% -0.03%
==========================================
Files 675 675
Lines 71274 71274
==========================================
- Hits 47136 47118 -18
- Misses 21493 21512 +19
+ Partials 2645 2644 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12300
The diff might seem bigger than necessary; this is because I have usedRemoved as per feedback.make proto-all
instead ofmake proto-gen
this time.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change