Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate x/auth/vesting to use app wiring #12301

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 18, 2022

Description

Closes: #12300

The diff might seem bigger than necessary; this is because I have used make proto-all instead of make proto-gen this time. Removed as per feedback.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
@julienrbrt julienrbrt changed the title feat: migrate vesting to use app wiring feat: migrate x/auth/vesting to use app wiring Jun 18, 2022
@julienrbrt julienrbrt force-pushed the julien/vesting-app-wiring branch from 311ad4d to 7580b1c Compare June 19, 2022 07:57
@github-actions github-actions bot removed the C:orm label Jun 19, 2022
@julienrbrt
Copy link
Member Author

julienrbrt commented Jun 19, 2022

Now that we have app wiring, this can happen: #9958 (I wondered why it was a module within auth, turns out there were already an issue for moving it 😄)

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #12301 (5a7e762) into main (6a844d3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12301      +/-   ##
==========================================
- Coverage   66.13%   66.10%   -0.03%     
==========================================
  Files         675      675              
  Lines       71274    71274              
==========================================
- Hits        47136    47118      -18     
- Misses      21493    21512      +19     
+ Partials     2645     2644       -1     
Impacted Files Coverage Δ
simapp/app.go 76.21% <ø> (-0.13%) ⬇️
x/auth/module.go 62.19% <100.00%> (+0.46%) ⬆️
x/distribution/simulation/operations.go 80.43% <0.00%> (-9.79%) ⬇️

@julienrbrt julienrbrt merged commit 2085850 into main Jun 20, 2022
@julienrbrt julienrbrt deleted the julien/vesting-app-wiring branch June 20, 2022 11:06
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate vesting to use app wiring
2 participants