-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bash testing cleanup #122
bash testing cleanup #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll fix up one or two comments then merge
# XXX Ex Usage: quickTearDown | ||
# Desc: close the test server, use with shunit2 OneTimeTearDown() | ||
quickTearDown() { | ||
printf "\n\nstopping $SERVER_EXE test server..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why printf over echo, but saw some links.... guess I need to update all the scripts now... (or maybe you did ;)
@@ -46,7 +84,10 @@ initServer() { | |||
fi | |||
} | |||
|
|||
# initClient requires chain_id arg, port is optional (default 46657) | |||
# XXX Ex Usage1: initClient $CHAINID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the XXX example header. 👍
|
||
# XXX Ex Usage: quickSetup $WORK_NAME $CHAIN_ID | ||
# Desc: Start the program, use with shunit2 OneTimeSetUp() | ||
quickSetup() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally nice to refactor out. Good call.
tests/cli/counter.sh
Outdated
@@ -75,8 +51,8 @@ test02GetCounter() { | |||
assertFalse "no default count" $? | |||
} | |||
|
|||
# checkAccount $COUNT $BALANCE | |||
# assumes just one coin, checks the balance of first coin in any case | |||
# CheckAccount $COUNT $BALANCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh... it was lower case due to the function name. Also wrong function. I'll fix it
Closes #118