Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use canonical golangci-lint github action #12134
chore: use canonical golangci-lint github action #12134
Changes from 1 commit
d952235
400fef3
960919a
9dffa36
edc57bb
4118316
9db408c
0b66c4d
241a808
3e991f1
f022bd3
75ef457
d801c2f
d2cabb0
30cb49a
9847ac8
b08f344
deffbbc
ea5438d
26036ef
95ac2de
075af32
a6f1498
18835a4
bd5667e
18becdf
d382053
388eff7
6b97db8
ca29bf1
a53a342
8961afe
a503ef7
c16f56e
3ae1cc6
9e1cbb4
d78d968
0461757
24c2175
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually opt to have this to not run this position of ci when there are no changes to the go code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend that we run it all the time since the compute to do that costs nothing and the previous setup resulted in not linting at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there's no sense in running it if there are zero code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can roll with it, I’ll make that change I’m just worried that I could introduce another bug that reproduces the prior state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change, after this we can look at merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to migrate away from this action since it doesn't support workspaces or multiple go.mods in a single repo for now.