Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add self delegations to genesis #1165

Closed
wants to merge 11 commits into from
Closed

add self delegations to genesis #1165

wants to merge 11 commits into from

Conversation

rigelrozanski
Copy link
Contributor

  • Updated CHANGELOG.md

@rigelrozanski rigelrozanski requested a review from ebuchman as a code owner June 7, 2018 21:47
@rigelrozanski rigelrozanski added the S:blocked Status: Blocked label Jun 7, 2018
@rigelrozanski
Copy link
Contributor Author

fix LCD tests to unblock this

@rigelrozanski
Merge pull request #1191: LCD Cleanup
1ca9b9d 
remove global variables from lcd

...

rebase fix

tests pass not using mock yet

move helper fn

...

changelog
@rigelrozanski
Merge pull request #1165: self delegations at genesis
eec9686 
changelog
@rigelrozanski rigelrozanski force-pushed the rigel/genesis-delegations branch from 3745ee6 to eec9686 Compare June 10, 2018 23:57
@rigelrozanski rigelrozanski changed the base branch from develop to rigel/lcd-fix June 10, 2018 23:59
@rigelrozanski rigelrozanski changed the base branch from rigel/lcd-fix to develop June 12, 2018 01:57
@cwgoes
Copy link
Contributor

cwgoes commented Jun 12, 2018 •
edited
Loading

Strange test failures: tests fail both on CI and on Rigel's laptop, pass on mine, no obvious relation between failing testcases and updated code.

I wonder if the tests are somehow timing dependent, and the new code changed how long certain store operations take?

edit: Got the tests to fail on my computer now, sometimes. Definitely seems like a timing issue.

@ebuchman
Copy link
Member

needs rebase

@cwgoes
Copy link
Contributor

cwgoes commented Jun 22, 2018

Maybe this should be merged into #1119 (cc @rigelrozanski)?

rigelrozanski added a commit that referenced this pull request Jun 22, 2018
@rigelrozanski
add self-delegations at genesis ref #1165
5dc163c
@rigelrozanski
Copy link
Contributor Author

@cwgoes done, added in new commit

@rigelrozanski rigelrozanski deleted the rigel/genesis-delegations branch June 22, 2018 18:49
cwgoes pushed a commit that referenced this pull request Jun 27, 2018
@rigelrozanski @cwgoes
Merge PR #1119: Unbonding, Redelegation
6f140d7 
* stake/fees spec updates
* staking overview.md revisions, moving files
* docs reorganization
* staking spec state revisions
* transaction stake updates
* complete staking spec update
* WIP adding unbonding/redelegation commands
* added msg types for unbonding, redelegation
* stake sub-package reorg
* working stake reorg
* modify lcd tests to not use hardcoded json strings
* add description update
* index keys
* key managment for unbonding redelegation complete
* update stake errors
* completed handleMsgCompleteUnbonding fn
* updated to use begin/complete unbonding/redelegation
* fix token shares bug
* develop docs into unbonding
* got non-tests compiling after merge develop
* working fixing tests
* PrivlegedKeeper -> PrivilegedKeeper
* tests compile
* fix some tests
* fixing tests
* remove PrivilegedKeeper
* get unbonding bug
* only rpc sig verification failed tests now
* move percent unbonding/redelegation to the CLI and out of handler logic
* remove min unbonding height
* add lcd txs
* add pool sanity checks, fix a buncha tests
* fix ante. set lcd log to debug (#1322)
* redelegation tests, adding query functionality for bonds
* add self-delegations at genesis ref #1165
* PR comments (mostly) addressed
* cleanup, added Query LCD functionality
* test cleanup/fixes
* fix governance test
* SlashValidatorSet -> ValidatorSet
* changelog
* stake lcd fix
* x/auth: fix chainID in ante
* fix lcd test
* fix lint, update lint make command for spelling
* lowercase error string
* don't expose coinkeeper in staking
* remove a few duplicate lines in changelog
* chain_id in stake lcd tests
* added transient redelegation
* 'transient' => 'transitive'
* Re-add nolint instruction
* Fix tiny linter error
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@rigelrozanski
Merge PR #1119: Unbonding, Redelegation
cb9bac5 
* stake/fees spec updates
* staking overview.md revisions, moving files
* docs reorganization
* staking spec state revisions
* transaction stake updates
* complete staking spec update
* WIP adding unbonding/redelegation commands
* added msg types for unbonding, redelegation
* stake sub-package reorg
* working stake reorg
* modify lcd tests to not use hardcoded json strings
* add description update
* index keys
* key managment for unbonding redelegation complete
* update stake errors
* completed handleMsgCompleteUnbonding fn
* updated to use begin/complete unbonding/redelegation
* fix token shares bug
* develop docs into unbonding
* got non-tests compiling after merge develop
* working fixing tests
* PrivlegedKeeper -> PrivilegedKeeper
* tests compile
* fix some tests
* fixing tests
* remove PrivilegedKeeper
* get unbonding bug
* only rpc sig verification failed tests now
* move percent unbonding/redelegation to the CLI and out of handler logic
* remove min unbonding height
* add lcd txs
* add pool sanity checks, fix a buncha tests
* fix ante. set lcd log to debug (#1322)
* redelegation tests, adding query functionality for bonds
* add self-delegations at genesis ref #1165
* PR comments (mostly) addressed
* cleanup, added Query LCD functionality
* test cleanup/fixes
* fix governance test
* SlashValidatorSet -> ValidatorSet
* changelog
* stake lcd fix
* x/auth: fix chainID in ante
* fix lcd test
* fix lint, update lint make command for spelling
* lowercase error string
* don't expose coinkeeper in staking
* remove a few duplicate lines in changelog
* chain_id in stake lcd tests
* added transient redelegation
* 'transient' => 'transitive'
* Re-add nolint instruction
* Fix tiny linter error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
S:blocked Status: Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rigelrozanski @cwgoes @ebuchman