Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: revert 10254 #10777

Merged
merged 1 commit into from
Dec 15, 2021
Merged

refactor: revert 10254 #10777

merged 1 commit into from
Dec 15, 2021

Conversation

alexanderbez
Copy link
Contributor

Description

Revert #10254

Closes: #10750


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review December 14, 2021 18:42
@alexanderbez alexanderbez requested a review from aaronc as a code owner December 14, 2021 18:42
@alexanderbez
Copy link
Contributor Author

cc @cmwaters

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for handling this, should we reopen the issue?

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 15, 2021
@mergify mergify bot merged commit 45cad1d into master Dec 15, 2021
@mergify mergify bot deleted the bez/revert-10254 branch December 15, 2021 10:21
@alexanderbez
Copy link
Contributor Author

thanks for handling this, should we reopen the issue?

I already did 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulations are failing on some PR's
4 participants