-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove json tag #10598
Merged
Merged
fix: remove json tag #10598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/auth
C:x/authz
C:x/feegrant
C:x/gov
C:x/slashing
C:x/staking
labels
Nov 23, 2021
amaury1093
reviewed
Nov 24, 2021
github-actions
bot
added
C:x/distribution
distribution module related
C:x/genutil
genutil module issues
labels
Dec 7, 2021
amaury1093
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @marbar3778 for this work!
LGTM, but imo failing tests and sims are related to this PR |
ill look into them today to get this merged |
tac0turtle
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Dec 20, 2021
@Mergifyio backport release/v0.45.x |
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2022
* remove json tag * fix compile * add changelog entry for breaking changes * remove last two jsontags * move chaglog to client * add json_name to pubkey * fix build * fix some json tags in tests * remove ormpb (cherry picked from commit 3cbc38d) # Conflicts: # CHANGELOG.md # proto/cosmos/auth/v1beta1/auth.proto # proto/cosmos/base/abci/v1beta1/abci.proto # proto/cosmos/distribution/v1beta1/distribution.proto # proto/cosmos/genutil/v1beta1/genesis.proto # proto/cosmos/gov/v1beta1/gov.proto # proto/cosmos/gov/v1beta1/tx.proto # proto/cosmos/slashing/v1beta1/tx.proto # proto/cosmos/staking/v1beta1/staking.proto # types/abci.pb.go # x/auth/types/auth.pb.go # x/distribution/types/distribution.pb.go # x/genutil/types/genesis.pb.go # x/slashing/types/tx.pb.go # x/staking/types/staking.pb.go
✅ Backports have been created
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:x/auth
C:x/distribution
distribution module related
C:x/genutil
genutil module issues
C:x/gov
C:x/slashing
C:x/staking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #9180
remove json tag from Protobuf files.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change