Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove json tag #10598

Merged
merged 16 commits into from
Dec 20, 2021
Merged

fix: remove json tag #10598

merged 16 commits into from
Dec 20, 2021

Conversation

tac0turtle
Copy link
Member

Description

Closes: #9180

remove json tag from Protobuf files.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review December 7, 2021 11:41
@github-actions github-actions bot added C:x/distribution distribution module related C:x/genutil genutil module issues labels Dec 7, 2021
@amaury1093 amaury1093 self-assigned this Dec 7, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @marbar3778 for this work!

CHANGELOG.md Show resolved Hide resolved
@amaury1093
Copy link
Contributor

LGTM, but imo failing tests and sims are related to this PR

@tac0turtle
Copy link
Member Author

ill look into them today to get this merged

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 20, 2021
@github-actions github-actions bot removed the C:orm label Dec 20, 2021
@tac0turtle tac0turtle merged commit 3cbc38d into master Dec 20, 2021
@tac0turtle tac0turtle deleted the 9180-remove-jsontag branch December 20, 2021 11:38
@tac0turtle
Copy link
Member Author

@Mergifyio backport release/v0.45.x

mergify bot pushed a commit that referenced this pull request Jan 3, 2022
* remove json tag

* fix compile

* add changelog entry for breaking changes

* remove last two jsontags

* move chaglog to client

* add json_name to pubkey

* fix build

* fix some json tags in tests

* remove ormpb

(cherry picked from commit 3cbc38d)

# Conflicts:
#	CHANGELOG.md
#	proto/cosmos/auth/v1beta1/auth.proto
#	proto/cosmos/base/abci/v1beta1/abci.proto
#	proto/cosmos/distribution/v1beta1/distribution.proto
#	proto/cosmos/genutil/v1beta1/genesis.proto
#	proto/cosmos/gov/v1beta1/gov.proto
#	proto/cosmos/gov/v1beta1/tx.proto
#	proto/cosmos/slashing/v1beta1/tx.proto
#	proto/cosmos/staking/v1beta1/staking.proto
#	types/abci.pb.go
#	x/auth/types/auth.pb.go
#	x/distribution/types/distribution.pb.go
#	x/genutil/types/genesis.pb.go
#	x/slashing/types/tx.pb.go
#	x/staking/types/staking.pb.go
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

backport release/v0.45.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth C:x/distribution distribution module related C:x/genutil genutil module issues C:x/gov C:x/slashing C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken links in ibc-go docs -- broken github workflow?
4 participants