-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: baseapp: add concurrent test for querying GRPCRouter #10371
test: baseapp: add concurrent test for querying GRPCRouter #10371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge this, but I think it could be improved too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. agree with @AmauryM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible let's add one more query worker in this PR - this way we close the issue.
Codecov Report
@@ Coverage Diff @@
## master #10371 +/- ##
==========================================
- Coverage 64.27% 64.27% -0.01%
==========================================
Files 572 572
Lines 54230 54230
==========================================
- Hits 34859 34858 -1
- Misses 17389 17390 +1
Partials 1982 1982
|
Runs 1,000 concurrent requests for baseapp.GRPCQueryRouter, this test requires that we enable: go test -race. Runs 2 different scenarios for the same handler: * same client connection being used concurrently * unique client connections Fixes #10324
Runs 1,000 concurrent requests for baseapp.GRPCQueryRouter,
this test requires that we enable: go test -race.
Closes #10324